Repository navigation
Sync lgse/strata#1822..#1800: Enter target, STL thumbnails, folder window titles, signed installer, activation GDK_DEBUG, reopen closed tabs - #36
Merged
Conversation
…ndow titles, signed installer, activation GDK_DEBUG, reopen closed tabs Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fazi6bx93e32CsuE8zqzMx
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fazi6bx93e32CsuE8zqzMx
…r, tabs, thumbnails Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fazi6bx93e32CsuE8zqzMx
…taller, preview gaps Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fazi6bx93e32CsuE8zqzMx
… tabs Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fazi6bx93e32CsuE8zqzMx
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fazi6bx93e32CsuE8zqzMx
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fazi6bx93e32CsuE8zqzMx
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #35
Stacked on #34. The base is #34's branch (
claude/friendly-cray-ftedea), whose watermarkc94eeb0is where this range starts, so the diff shows only the new range. When #34 (and #32 under it) merge, retarget this PR tomain. This session could push only to its own branch.Upstream range
c94eeb0020fa1154e11c741888f1b56d92ce70d6→bf26829b4fd74c1f25ac170aad9521a633234a30: 8 PRs, no direct pushes.sources.yamlholds the new watermark.ghis unauthenticated here, as in #28, #32 and #34. Sodriftandqa --prran on scratchdata/prs.jsonlrows built from the local upstream clone: first-parent commit, file list, and UTC commit time. PR bodies, issues and comments were read through the GitHub MCP tools.data/prs.jsonlis not committed.browser/search/filterbrowser/thumbnails/workersapp/window(scope)app/packaging/installerintegration/file-manager-interface/service-activationbrowser/tabsandbrowser/view-modesPer node
New and promoted nodes
integration/file-manager-interface.md→file-manager-interface/index.md. The id is unchanged.integration/file-manager-interface/service-activation, "Launched-program GDK_DEBUG restore".{issue: lgse/strata#1810, pr: lgse/strata#1811}.code: [src/child_environment.rs],tests: [src/child_environment/tests.rs].GDK_DEBUG. Its Design records the Flatpak rationale.site/unguided.yaml("New since v1.0.0…"), per Sync step 4.app
app/packaging/installer(#1825). Summary, plus a rewrite of these sections:openssl, the size caps, the signature and digest failures, and the order of checks. Thegh/.sha256bullets are removed.--without-*flags.--with-*.Design: the #731 and #331 bullets are replaced by #1817 comment rationale, the trust-root rule and the default-on rule.
docsgainsdocs/signed-updates.md. The #334 gap is dropped (see Needs a person).app/infrastructure: new### File manager activationgroup (#1811). It covers the--gapplication-serviceno-portalsre-exec, which launches are untouched, flag detection, and reuse by later launches. Three Design bullets, anddocsgainsdocs/packaging.md. No row: the row is on the new child.app/window: #1827 row. The false bullet "A browser window's title is 'Strata'" was dropped; title behavior lives onbrowser/tabs.app/shortcut-reference: the F1 "Reopen the last closed tab" bullet (#1800), with no row.app/packaging:reviewed_atonly.browser
browser/search/filter(#1822).codegainssrc/ui/enter_target.rsandtestsgainssrc/ui/enter_target/tests.rs.### Enter targetgroup: the outline, pick rule, query edits, same-query updates, scroll-follow, Down, Space, and the 10xer off-switch.browser/view-modes/columns: Columns-specific Filter field bullets: Enter with no pick, Down, Right. These cite #1822 with no row.browser/thumbnails: new### STL model thumbnailsgroup (#1789). The false Formats bullet ("STL keeps its icon") is fixed. Four Design bullets.testsgainstests/qa/mutations/stl-thumbnails-live-preference.patch.browser/thumbnails/workers: #1789 row. One STL render at a time, a one-shot sandbox, and Quick Preview not waiting for the slot. Design gains the #1788 prototype figures.browser/tabs:### Reopeninggroup: Ctrl+Shift+T, 20 entries, per window.### Window titlegroup (#1827/#1824).testsgainstabs/tests/reopen.rs.browser/view-modes: #1800 row for the column moves, becausesrc/ui/browser_modes.rsis its code.browser/view-modes/list/column-layout: the false Reordering bullets (live swaps, saving on every swap) are rewritten for the 3 px insertion line and apply-on-release. They cite #1800 with no row.reviewed_atonly: context-menu, folder-customization, navigation/startup-arguments, sidebar, view-modes/density, view-modes/list.integration and devices
integration/file-manager-interface(parent): Design gains the 25 s cold-activation wait (#1810) and a pointer to the child. The packaging bullet now saysinstall.shinstalls the service by default since #1825.integration/portal-file-chooser/setup: the Design "Replacement is opt-in" bullet now says the installer installs it by default (#1825).devices/volumes/udiskie-unlock: the Summary says the installer enables it by default on Arch-based systems withudiskieonPATH(#1825).devices/volumes/encrypted: the Design "opt-in handoff" bullet now cites the same default.reviewed_atonly: 10xer-mode/file-chooser, 10xer-mode/search, open-with, open-with/terminal, portal-file-chooser.preview, settings, operations, remote
settings/themes: the STL model thumbnails switch: off by default, its subtitle and the saved key (#1789).settings/preferences: the 3d/mesh/printing search aliases (#1789, unverified).preview/preview-panel/model-views:### Background thumbnail renders: SIGKILL plus a detached reaper on cancel, the 12 s deadline, or a monitor failure.preview/preview-panel: drawer and Quick Preview models keep an opaque surface (#1789).preview/preview-panel/layout: Known gap from the #1822 body: after a query edit drops a previewed pick, Columns and Icons show "No preview for this selection" while List closes the drawer.preview/preview-panel/sandbox:relatedgains model-views.remote/file-providers/network-locations: the "window title" clauses in two #1726/#740 bullets are removed. The OS title is now owned bybrowser/tabs, andrelatedgainsbrowser/tabs.reviewed_atonly: operations/progress/jobs, preview/preview-panel/documents, remote/file-providers/external, settings/preferences/storage.Every node
driftlisted is now atreviewed_atbf26829. Nodes whose content changed arereview: draft.QA
All 8 sweeps'
reviewed_atare now bf26829..sha256probe and theghstub.install.shwith the fixture key.opensslwithout Ed25519;--with/--withoutordering;app/infrastructure: coldOpenDirectorytiming through xdg-desktop-portal 1.22.1, withGDK_DEBUGvariants set through the activation environment; later launches.browser.### …/service-activationprobes:GDK_DEBUG;app.stl_thumbnailsvalues.--without-udiskie-unlock.reviewed_atonly.Tier-1 plans (
qa --pr N --tier 1). No plan lists "Unmapped changes".browser/search/filter(owner), view-modes, columns, list, app/window, 10xer-mode/file-chooser and search, app/infrastructure. Sweeps: app, browser, integration (src/style.cssforces app).browser/thumbnails/workers(owner), thumbnails, preview-panel, model-views, sandbox, settings/themes, settings/preferences and storage, plus shared-test nodes. Sweeps: app, browser, preview, settings.style.css,preferences.rsand locale triggers).Needs a person
Placements
browser/view-modes, which ownsbrowser_modes.rs. The Reordering bullets stay onlist/column-layout, as they have since #1651, whosecodeis onlycolumn_options.rs. Pick one node for both.src/ui/thumbnail.rs(browser/thumbnails), but it sits onworkersbeside the existing admission bullets, which already have the same mismatch.app/windowby scope, while the bullets are onbrowser/tabs, which implements them. The initial "Strata" comes fromsrc/ui/window.rs, which no node owns.stl_thumbnailskey: it is saved insrc/ui/preferences.rs, which no node owns. The bullet follows theshow_thumbnailsprecedent onsettings/themes.model-views:src/sandbox/model.rsis model-views' code, so a background-reaping bullet now sits on a node about camera views.src/ui/chooser/tests/keyboard.rs: its new #1822 test,enter_in_the_filter_field_chooses_the_top_result_in_every_view, belongs tointegration/10xer-mode/file-choosertests, not to filter.Proposed child, not created:
browser/search/filter/enter-target. Origin #1643/#1822, its own modulesrc/ui/enter_target.rs, and its own tests. It would promotefilter.mdtofilter/index.md.scopes.yaml:startupstaysnull. No new scope was added.Possible upstream bugs, found by code reading. An lgse/strata issue search found none covering them; no issue was filed.
src/portal_setup/udiskie.rs:997-1008(spawn_detached_with) does not callchild_environment::restore_command.GDK_DEBUG=…no-portalsandSTRATA_ORIGINAL_GDK_DEBUG.strata --udiskie-hookchildren inherit both too.src/services/integration_catalog.rs:697,src/services/update_install.rs:763, and thelsblkcalls insrc/ui/window/drive_ops.rs.install.sh.README.md:~417says "Unattended installer opt-in is--with-udiskie-unlock", andREADME.md:63-64says the file chooser and udiskie are opted into through the installer. Since #1825, both are on by default where supported.resolve_default_integrationssetsWITH_SMBandWITH_RAW, so an unattended plan prints "+ Windows network shares" / "+ Camera RAW support" even when the packages are installed. Recorded as(unverified)on the installer.Deferred or limitations with no issue (not recorded as gaps):
BrowserViewis still alive 5 s after close (#1800 review).main/install.shinto bash. The old gap cited the now-closed Strengthen Strata’s installer and self-update security lgse/strata#334, so it was dropped.Site (for the release docs run, not this sync):
site/src/reference/preview-sandbox.md:~124: "There is no geometry thumbnail for STL".site/src/reference/install.md:gh/.sha256verification and opt-in defaults.site/src/reference/portal-file-chooser.md:~116: "installer opt-in".(unverified)claims added (33):no-portalsflag in any separator or case.~and/titles;#ccccccshading and the default camera;.STLcase.GDK_DEBUGthrough.Review loop
Three rounds, with fresh reviewers each round. I checked each blocking finding against the code or sources before accepting it.
curl --max-filesize), not the digest check.settings/themes, whilesearch.rsis preferences code.src/main.rs, so they moved back toapp/infrastructure. The child keeps only the restore.preview-paneltolayout, which ownssession.rs.preview-panelandbrowser/thumbnails.network-locations"window titles" clause, and probe duplicates.install.sh's own size message was dropped. Round 3 said that message still fires when the size is not known up front (install.sh:1023-1029). The node now says only that curl's cap fails the download step.workersfor the helper overlap. Round 1 had dropped it as a duplicate of themodel-viewsgap, so only the Behavior qualifier was added.check: 0 errors and 25 warnings, all site-release staleness (v1.0.0 against v1.1.0). Unit tests pass.🤖 Generated with Claude Code
https://claude.ai/code/session_01Fazi6bx93e32CsuE8zqzMx