Repository navigation
Sync lgse/strata#1830, #1834, #1838: ODT previews, run directory fallback, icon tile - #38
Merged
Merged
Conversation
…back, icon tile - preview: render ODT and OTT documents; DOCX and ODT always wrap (lgse/strata#1834) - operations/integration: Actions run directory falls back to the user cache directory, never /tmp/strata (lgse/strata#1830) - app/packaging: colored logo on a gradient rounded tile (lgse/strata#1838) - Advance the watermark to 2218357c. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016YcVff1SP7CP7vXCsQ6hKD
5 tasks
Promote documents.md to documents/index.md and give ODT and OTT their own node (origin lgse/strata#1813, lgse/strata#1834) owning src/services/odt.rs. Move the DOCX/ODT always-wrap bullet to preview-panel, which decides it in src/ui/preview.rs, and list the new node in site/unguided.yaml. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016YcVff1SP7CP7vXCsQ6hKD
…ws, privacy fixes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UDGHgPPbPSoQNyPdmyFNpq
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UDGHgPPbPSoQNyPdmyFNpq
…d settings saves Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015rmfTXdVg1CEGCkG21C8Au
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015rmfTXdVg1CEGCkG21C8Au
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015rmfTXdVg1CEGCkG21C8Au
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015rmfTXdVg1CEGCkG21C8Au
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015rmfTXdVg1CEGCkG21C8Au
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015rmfTXdVg1CEGCkG21C8Au
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015rmfTXdVg1CEGCkG21C8Au
…robe and wording fixes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015rmfTXdVg1CEGCkG21C8Au
…earch, preview fixes Syncs lgse/strata#1904, #1898, #1899, #1906, #1908, and #1901 (be3343a..923b39d) and advances the watermark. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23A9aNN8aT7Tpt3zouac
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23A9aNN8aT7Tpt3zouac
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23A9aNN8aT7Tpt3zouac
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23A9aNN8aT7Tpt3zouac
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23A9aNN8aT7Tpt3zouac
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23A9aNN8aT7Tpt3zouac
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23A9aNN8aT7Tpt3zouac
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23A9aNN8aT7Tpt3zouac
Sync lgse/strata#1898–#1908: Save stem selection, multi-word global search, preview fixes
Sync lgse/strata#1872–#1896: accessible names, menus past the window, shared settings saves
Sync lgse/strata#1831–#1871: tabs from drags, G-code and route previews, privacy fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #37
Upstream range
bf26829b4fd74c1f25ac170aad9521a633234a30→2218357c2e91c0c3e6cd02638356f7a91c08bcae: 3 commits and 3 PRs, with no direct pushes and no triage.sources.yamlholds the new watermark.GitHub GraphQL is not available from this session, so
driftandqa --prran on scratchdata/prs.jsonlrows. I built those rows through the REST API with the script's ownpr_row().data/prs.jsonlis not committed.integration/custom-actions(drift, via theactionsscope)preview/preview-panelapp/packagingPer node
New and promoted nodes
preview/preview-panel/documents.md→documents/index.md. The id is unchanged.preview/preview-panel/documents/odt, "ODT and OTT document previews". The owner chose a separate node.{issue: lgse/strata#1813, pr: lgse/strata#1834}.code: [src/services/odt.rs].tests: [src/services/odt/tests.rs, tests/fixtures/documents/report.odt, tests/qa/scenarios/quick_preview/sandboxed-office-shared-preview.jsonl].odt.rsimplements, plus the ODT reader Design and the ODT-only Known gaps (images and thumbnail fallback,.fodt).driftstill namespreview/preview-panelfor #1834, so the row stays there.site/unguided.yamlas "New since v1.0.0…", per Sync step 4.integration
integration/custom-actions: History row for #1830. The bullet "Each invocation gets a private 0700 scratch folder inSTRATA_ACTION_RUN_DIR…" (#1085) moved tooperations/progress/jobs, becausesrc/adapters/local_jobs.rsimplements it (Behavior placement).operations
operations/progress/jobs: new### Run directorygroup (#1830):$XDG_RUNTIME_DIR/strata/actions/<pid>-<n>.~/.cache/strata/actions/fallback, with nothing under/tmp/strata.$XDG_CACHE_HOMEfallback.A new Design bullet cites #1821 for the risk, which was never reproduced, and its suggested fixes, and #1830 for the fix it chose. No History row, per Row placement.
reviewwent fromreviewedtodraft.app
app/packaging: History row for #1838.layersglyph on a backdrop" sentence. The SVG #182 merged was already the white Strata logo. Added sourced bullets on the single-SVG choice (#1832 options), the gradient and edge (#1838 second commit), the self-rounded corners (MacTahoe), and the 228/284 tile with a 51-unit radius.app/infrastructure: #1834 touched onlysrc/services/mod.rsandtypos.toml. No content changed.preview
preview/preview-panel: History row for #1834.documentsbecauseui/preview.rsandadapters/local_preview.rsimplement them. The new wording: "No preview for this selection" for recognizable names, and "Copy this file locally…" only when the content type reveals the format..odtpreviews as text..h264on systems whose MIME database types itapplication/octet-stream(#1861).preview/preview-panel/documents:testsgainstests/fixtures/documents/report.docxandtests/fixtures/documents/README.md, which describes both fixtures.odtchild. The Summary names the child.preview-panel, becausesrc/ui/preview.rsdecides it.preview/preview-panel/layout: DOCX/ODT/OTT now center at 1280 px whatever the wrap setting. The left-edge bullets are limited to workbooks, and to Markdown/HTML/RTF with wrap off.preview/preview-panel/find: ODT/OTT prose is searchable.preview/preview-panel/sandbox:docx/odtformat argument (#1834). The symlink clause is attributed to #1276.preview/preview-panel/media: qualified the bare.h264bullet, which needs a MIME database that types the stream as video (#1861).preview/preview-panel/model-views,preview/quick-preview. Theirreviewed_atis not moved.QA
operations/progress/jobs(+operations/progress)operationspreview/preview-paneland its childrendocuments,documents/odt,find,layout,model-views,sandbox;preview/quick-preview;app/infrastructurepreview,appsrc/services/odt.rs,src/services/odt/tests.rs,tests/fixtures/documents/README.md,report.odt)app/packaging(+aur,installer)appUnmapped-file assignments (ownership rule 1):
src/services/odt.rs→documentscode: it implements ODT rendering.src/services/odt/tests.rsandtests/fixtures/documents/report.odt→documentstests.tests/fixtures/documents/README.mddescribes those fixtures. No node lists it explicitly, and it is no longer flagged. Narrowingtests/fixtures/documentsto the two report files left it unlisted; it is fixture documentation, not a feature.Sweeps touched, all with
reviewed_atmoved to2218357c:app:app/packagingprobes for icon sizes, backgrounds, and themes.integration:reviewed_atonly. Thecustom-actionsprobes still hold.operations:operations/progress/jobsprobes: theXDG_RUNTIME_DIR/XDG_CACHE_HOMEcombinations while an Action runs, and/tmp/strata/actionsowned by another user.preview:preview-panel,documents,find, andsandboxfor remote/text-named ODT, header rows, preformatted links, deep nesting, long paragraphs, omitted content, and oversized/broken ODT inputs.Needs a person
integration/custom-actionsthrough theactionsscope, while the code and Behavior sit onoperations/progress/jobs. I followed drift.create_run_directory(src/adapters/local_jobs.rs:509-547) still checks ownership only of<root>/strata/actions, not its parents, and works by path names. This is the residue of #1821 (now closed). It matters only whenXDG_RUNTIME_DIRorXDG_CACHE_HOMEpoints at a shared directory.src/adapters/local_jobs.rs:508: "The temporary-directory fallback may be shared with other users".Thumbnails/thumbnail.pngfallback: the #1834 review comment recommends a follow-up issue, and none exists. The Known gap cites #1834 and #1813 for now.site/src/reference/document-previews.mdstill says DOCX doesn't wrap and that ODT is unsupported. The remote-files sentence omits ODT. Separately,checkwarns that the latest stable upstream release is v1.1.0 while the site describes v1.0.0, so adocs-updaterun for v1.1.0 is due.(unverified)claims added or changed:app/packaging: icon gradient colors and direction (from the SVG).operations/progress/jobs:<pid>-<n>naming under$XDG_RUNTIME_DIR.$XDG_CACHE_HOMEfallback.gutils.c).documents/odt:.ODT/.OTT.Title/Subtitle.text:line-breakandtext:list-header.find: ODT prose is searchable.preview-panel:.odt/.ott.layout: centering at 1280 px, and workbooks start at the left edge.sandbox: the 20 MiB message, and the helper-failure message.Review loop
Three rounds, with fresh reviewers per area each round. A separate verifier checked each blocking finding before any fix.
Round 1:
Round 2:
custom-actionsandjobs: confirmed in code and moved.preview, "cells ignore paragraph emphasis" was false (odt.rs:582-598)..h264contradiction withmedia, probe placement, sentence lengths).Round 3:
app/operations: two over-length sentences, fixed.preview: no blocking findings. Minors fixed: the cell-heading wording, and Setup naming for the ODT samples.preview-panel.ODT split: after the owner's decision, a fresh reviewer checked the split.
odt(odt.rs:782againstdocx.rs:129).odt, while its Behavior lives onpreview-panelanddocuments.odttests, a Design antecedent, and a note on the sharedRichTextDatanotice.scripts/featuremap.py checkreports 0 errors. Its 25 warnings are all site/release staleness (v1.1.0). The unit tests pass (39).https://claude.ai/code/session_016YcVff1SP7CP7vXCsQ6hKD
Generated by Claude Code