Repository navigation
Conversation
…rs, typed-path preview Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23ACnumbXzpecuKnNsx6
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23ACnumbXzpecuKnNsx6
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23ACnumbXzpecuKnNsx6
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23ACnumbXzpecuKnNsx6
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23ACnumbXzpecuKnNsx6
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23ACnumbXzpecuKnNsx6
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23ACnumbXzpecuKnNsx6
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23ACnumbXzpecuKnNsx6
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23ACnumbXzpecuKnNsx6
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23ACnumbXzpecuKnNsx6
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23ACnumbXzpecuKnNsx6
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23ACnumbXzpecuKnNsx6
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23ACnumbXzpecuKnNsx6
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23ACnumbXzpecuKnNsx6
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23ACnumbXzpecuKnNsx6
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23ACnumbXzpecuKnNsx6
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23ACnumbXzpecuKnNsx6
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQ23ACnumbXzpecuKnNsx6
5 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #45
Closes #46
Read this first
resync/full-audit) already syncs fix(keyboard): preserve focus across dialogs, tabs, and drags lgse/strata#1900 and moves the watermark to86df474. It also changes AGENTS.md, the skill, and the tooling. This PR branches from Full resync at lgse/strata 86df474: codified standards, tooling fixes, every node re-verified #45's head and targets its branch, so it covers only fix(ui): square uncomposited popovers and preview path-bar files lgse/strata#1912 and #1885. When Full resync at lgse/strata 86df474: codified standards, tooling fixes, every node re-verified #45 merges, GitHub retargets this PR tomain.(unverified)Behavior.review: reviewed.gh apifollows the files endpoint'sLinkheader to arepositories/<id>/…URL, and this session's proxy refuses those (HTTP 403).driftandqa --prtherefore ran on scratchdata/prs.jsonlrows. A script built them over REST, paging with explicitpage=N.checkreports 0 errors and 25 warnings. The warnings are the existing site v1.0.0 vs v1.1.1 ones. All 48 unit tests pass.Upstream range
86df474dc0e8352e0e2098637a017cc4c77a8c44(#45's watermark) →73b3258ff9da7fd5f8b279e442e4fbf576850deb: 2 commits, 2 PRs, no direct pushes. Every touched node and sweep is reviewed at73b3258.settings/themes(fix 1);browser/navigation/location-bar(fix 2)app/keyboard-shortcuts/remappingdriftput both PRs in triage because each touches several features.Per node
New and promoted
app/keyboard-shortcuts.md→app/keyboard-shortcuts/index.md. The id is unchanged.app/keyboard-shortcuts/remapping, origin{issue: lgse/strata#1884, pr: lgse/strata#1885}, shipped, draft.src/ui/keys/{command,alias,capture,conflicts}.rs,src/ui/preferences/keymap.rs,src/ui/window/keyboard/direct.rs,src/ui/settings/keyboard.rs.keyboard_dispatch/{keymap_overrides,keymap_conflicts,structural_aliases,direct_commands}.rs, andtests/qa/scenarios/keymap.docs/keymap.md.settings.toml[keymap.default]/[keymap.tenxer]overrides<Control>ampersand. Both cite #1885.site/unguided.yaml.app
app/keyboard-shortcuts: AltGr or a layout switch no longer cancels an armed chord. Labels leave out keys that never fire, with the type-to-search Rename example.app/shortcut-reference:app/window/key-dispatch:ycopies no path while filter results show (#800, #1885).accessibility,dialogs,window,infrastructure:reviewed_atonly.browser
browser/navigation/location-bar: #1912 row.tests+=tests/qa/scenarios/keyboard_navigation/list-typed-file-path.jsonl, moved from keyboard-navigation, which now lists its 12 other scenario files explicitly.browser/navigation: Back, Forward, Parent, and Home bound to a Ctrl or Super key now fire with the file list focused. Covers which table each reads in 10xer, and the Shift-ignoring match (unverified).browser/navigation/location-bar/completion:focus_next/focus_previouskeys complete like Tab. Page Down/Up stay physical keys (unverified).browser/context-menu: menu hints and accelerators follow default-table rebinds.browser/view-modes/thumbnail-size: the Ctrl+Alt step keys come from[keymap.default]in both modes. This bullet moved from remapping.browser/search/filterandbrowser/sidebar/pins: pre-existing bugs from #1885's body, as(unverified)Behavior (see Bugs).reviewed_atonly.integration
integration/custom-actions:integration/10xer-mode/file-verbs:No action N,No matching actions.Nothing to …flashes. The Columns fallback is unverified.integration/10xer-mode/preview-keys:first_item/last_itemworks in document and archive previews.integration/10xer-mode/places: gap: withgunbound, the pin flash ends in "as" with no key.integration/portal-file-chooser: Back, Forward, Parent, and Home bound to a Ctrl key work in the chooser. In 10xer mode, the chooser reads them per command from the two tables (unverified).reviewed_atonly.operations
operations/trash:left,right,activate, andconfirm_trashentries (#1885).operations/clipboard:reviewed_atonly. Theybug moved to key-dispatch, whose code blocks it.preview
preview/preview-panel/mediatopreview/quick-preview, which ownssrc/ui/preview/keyboard.rs. Citations are unchanged.media_seek_end;media_volume_step_upholds+and=.### Slider keys.preview/preview-panel/documents: Home and End keep moving the caret afterfirst_item/last_itemrebinds (docs/keymap.md).preview/preview-panel/find: the tooltip follows afind_in_previewrebind (unverified).reviewed_atonly.settings
settings/themes: #1912 row.### Uncomposited displaysgroup: without a compositor, popovers, menus, and tooltips are square with no shadow.popoverrule wins.settings/themes/corner-roundness: caveat that uncomposited popups stay square at every value (#1912).settings/preferences:icons,preferences/storage:reviewed_atonly.scopes.yamlis unchanged.QA
Sweeps touched:
app,browser,integration,operations,preview,settings(reviewed_atset on all six).escapepage_downPATH; partial matches; second Columns column and Iconsfrfirst_item/last_itemon F7/F8last_item,media_seek_end,media_volume_step_up, andpage_downappandbrowser### preview/preview-panel/mediato### preview/quick-preview.list-typed-file-pathcoverage now sits under location-bar.qa --pr N --tier 1). No plan had "Unmapped changes".app/infrastructure,browser/navigation/location-bar,settings/themes. Sweeps:app,browser,settings.app/keyboard-shortcuts/remapping. Sweeps:app,browser,integration,operations,preview,settings.Needs a person
src/ui/keys/bindings/**),settings.rs,clippy.toml, icons, and README stay onapp/infrastructure.settingstrigger.src/app/browser.rsstays abrowsertrigger.src/ui/window/keyboard/items.rscarries Copy path, pin, and the navigation jumps. It is anappsweep trigger with no node, so its bullets sit on the features they serve.### Slider keysbullets onpreview/preview-panel/mediaare implemented insrc/ui/preview.rs(preview/preview-panelcode). They were left in place.scopes.yaml:keys: app/keyboard-shortcuts/remapping. Its only PR landed there. Not added, because one PR is thin evidence.(unverified)claims added: 48. List them withgit diff origin/resync/full-audit...HEAD | grep '^+' | grep '(unverified)'.Bugs and upstream doc contradictions
None was filed upstream. Issue search (
search/issues) is blocked in this session. For the four pre-existing #1885 bugs, research listed all 1007 lgse/strata issues, open and closed, over REST and searched titles and bodies; none covers them. The code-reading bugs below were not searched.(unverified)Behavior on their code owners:operations/trash).browser/search/filter).pafter clicking a folder pins nothing (browser/sidebar/pins).ycopies no path while filter results show (app/window/key-dispatch).confirm_delete(permanent)serves both keys (src/ui/window/keyboard/items.rs:87-104). It opens the permanent-delete confirmation for the deselected row. Not recorded in a node.src/ui/settings/search.rs:419-522). Recorded(unverified)onsettings/preferences.[keymap.tenxer], such as Alt+H, is let out of a focused preview but toggles nothing.preview.rs:343,files.rs:87-89,commands.rs:273.(unverified)onpreview-keys.find_in_previewunbound, the find button's tooltip reads "Find in preview ()" (src/ui/preview/find.rs:326-329uses rawt!; no keyless entry inshortcut_reference.rs). Not recorded in a node.notify::compositedhandler from #1912 is never disconnected. The maintainer called this harmless. Not recorded.73b3258:docs/preferences.md:105: says corner roundness applies live across menus. Without a compositor, #1912 squares popups. wmfeht flagged this on #1912.docs/keymap.md:108-110: puts the Search keybinds field above the Default/10xer switch. The code puts the switch first (src/ui/settings/keyboard.rs:44-80).docs/keymap.md:40-41: says the chooser's own keys use the default table in both modes. The chooser readsparent_folderandhome_folderfrom the 10xer table in 10xer mode (src/ui/chooser.rs:2842-2847,3074-3083).docs/keyboard-shortcuts.md:376: gives Ctrl+A as an alias key that saves with a note. Ctrl+A on an arrow command is refused as a duplicate of Select all (src/ui/keys/conflicts.rs:720-809).Site pages made stale (for the next release docs run; not edited)
guide/keyboard.mdandreference/keyboard-navigation.md: remappable keys and the Settings → Keyboard page.reference/10xer-mode.mdandguide/10xer.md: rebindable 10xer tables and direct commands.guide/settings.md: the Keyboard page and search.guide/themes.mdandreference/themes.md: uncomposited popups.reference/custom-actions.mdandguide/actions.md: Custom action slots.guide/previews.md: typed-path Quick Preview and the timeline keys.reference/portal-file-chooser.md: rebinds in the chooser.Review loop
Three rounds, with one fresh adversarial reviewer per area each round (operations was paired with settings in round 3). A fresh verifier checked each blocking finding before any fix.
ybug on the wrong node (moved to key-dispatch)(unverified)Behavior.integration/custom-actions, whoselistedorder decides slots(unverified)":docs/keymap.md:24-25states themfirst_itembullets need(unverified)": comment 6434407976 states themsettings/preferences: a Keyboard section heading with no matching row is hidden during search (search.rs:630-645).settings/themes: Appearance text-size keycaps follow rebinds (src/ui/settings/theme.rs:424-466).operations/trash:84: still names Escape, now the remappableescapeentry. No probe covers rebound trash-dialog keys.integration/portal-file-chooser:settings.tomloverrides apply in the chooser (testchooser/tests/keyboard.rs:990-1031)file-verbsSummary does not mention default-map direct verbs.Generated by Claude Code