Add --enable-dh for FIPS builds for testing - #496
Merged
Merged
Conversation
padelsbach
changed the title
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The documented manual FIPS build remains missing the newly required DH option.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds DH support to FIPS wolfSSL builds to resolve v7 CI failures.
Changes:
- Adds
--enable-dhto default FIPS configuration. - Updates the copyright year.
| File | Description |
|---|---|
scripts/utils-wolfssl.sh |
Enables DH in FIPS builds. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
aidangarske
previously approved these changes
Oct 1, 2026
ColtonWilley
previously approved these changes
Oct 1, 2026
padelsbach
dismissed stale reviews from ColtonWilley and aidangarske
via
October 1, 2026 17:21
3107203
ColtonWilley
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
--enable-dhto FIPS builds for v7 update in 5.9.4, where DH is no longer in the boundary. Fixes CI failures on master.