Repository navigation
ci: report unexpected openvpn failures under force-fail - #511
Open
yosuke-wolfssl wants to merge 1 commit into
Open
yosuke-wolfssl wants to merge 1 commit into
yosuke-wolfssl wants to merge 1 commit into
Conversation
- check-workflow-result.sh's openvpn branch writes the actual-minus-expected failures to extra_sorted.txt and strips the optional tests from that file, in place of passing the list to comm as a filename. - The optional-failures line lists the optional tests that actually failed.
There was a problem hiding this comment.
🟢 Approval recommended
The updated comm operations correctly use sorted files and implement the described failure classification.
0 open findings
What changed in this PR
Fixes OpenVPN force-fail reporting so unexpected and optional failures are classified correctly.
Changes:
- Stores unexpected failures in a sorted temporary file.
- Excludes optional failures while reporting only optional tests that actually failed.
| File | Description |
|---|---|
.github/scripts/check-workflow-result.sh |
Corrects OpenVPN failure-set comparisons. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the openvpn force-fail branch of
check-workflow-result.sh, the secondcommcall received the list of unexpected failures as a string, wherecommexpects a file.commfailed withcomm: 'provider_testdriver ': No such file or directory. The pipeline's exit status came fromtr, soset -edid not stop the script, andEXTRAwas always empty. As a result, a force-fail cell could never report a test that failed unexpectedly. The "optional" line also printedprovider_testdriverevery time, whether or not that test failed.All 6 openvpn force-fail cells in nightly run 36822568609 log the
comm:error.Fix (
.github/scripts/check-workflow-result.sh)EXTRA_SORTEDis a sorted file of the tests that failed but are not in the expected list.EXTRAis that file minus the optional tests.OPTIONAL_FAILSlists the optional tests from that file, so it names only optional tests that actually failed.In the nightly, every force-fail cell failed the 4 expected tests plus
provider_testdriver, which is optional, so these cells stay green. Any other failure now turns the cell red.Verification
Ran the script against hand-made
openvpn-test.logfiles:FAIL:linesprovider_testdrivercomm:errormisc_testdrivermisc_testdriverprovider_testdriver+misc_testdrivermisc_testdriverci:openvpn: