puf: fix transmit-only UART HAL and add an interactive INTERACTIVE=1 demo mode - #623
Merged
Merged
Conversation
dgarske
force-pushed
the
puf_interactive_uart
branch
5 times, most recently
from
September 1, 2026 20:00
5ebd9b9 to
3ba6cda
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
aidangarske
reviewed
Sep 2, 2026
aidangarske
left a comment
aidangarske
left a comment
Member
There was a problem hiding this comment.
Do we want to add some CI for the PUF work we have now or at least build it in CI?
dgarske
force-pushed
the
puf_interactive_uart
branch
from
September 2, 2026 18:51
3ba6cda to
67b04e3
Compare
aidangarske
requested changes
Sep 9, 2026
aidangarske
left a comment
aidangarske
left a comment
Member
There was a problem hiding this comment.
Skoll Code Review
Scan type: review-security
Overall recommendation: REQUEST_CHANGES
Findings: 3 total — 3 posted, 0 skipped
3 finding(s) posted as inline comments (see file-level comments below)
Posted findings
- [High] Failed PUF readout falls back to a device-independent key —
puf/main_interactive.c:439-446 - [Medium] Unauthenticated UART commands disclose PUF-derived key material —
puf/main_interactive.c:151-155 - [Low] Interactive recovery and UART parsing have no behavioral test coverage —
.github/workflows/puf.yml:70-76
Review generated by Skoll
dgarske
force-pushed
the
puf_interactive_uart
branch
from
September 9, 2026 16:55
67b04e3 to
5eb1ee1
Compare
aidangarske
previously approved these changes
Sep 9, 2026
dgarske
force-pushed
the
puf_interactive_uart
branch
from
September 9, 2026 20:25
5eb1ee1 to
fc38ca0
Compare
dgarske
force-pushed
the
puf_interactive_uart
branch
from
September 10, 2026 15:50
fc38ca0 to
ef81819
Compare
aidangarske
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.