Skip to content

CI: drop NetXDuo install.sh from the ThreadX build for performance - #11624

Open
padelsbach wants to merge 1 commit into
wolfSSL:masterfrom
padelsbach:ci-pkg-download
Open

padelsbach wants to merge 1 commit into
wolfSSL:masterfrom
padelsbach:ci-pkg-download

Conversation

@padelsbach

Copy link
Copy Markdown
Contributor

Description

Observed timeouts on the ThreadX workflow (10 min), turns out it downloads ~600MB of packages which are either already on the runner or not used. This has occured on about 1.4% of runs in recent weeks.

Saves about 1.5 min per run, 28 runner hours per month.

Example: https://github.com/wolfSSL/wolfssl/actions/runs/36892918725/job/110472707120?pr=11618

Testing

CI

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

Copilot AI balanced review requested due to automatic review settings October 1, 2026 17:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused workflow change preserves existing build steps while eliminating unnecessary dependency downloads.

Review effort: Balanced
Findings: None

What changed in this PR

Removes an unnecessary NetXDuo dependency installation step to reduce ThreadX CI runtime and timeout risk.

Changes:

  • Skips NetXDuo’s package-heavy install.sh.
  • Documents why the script is intentionally omitted.
File Description
.github/​workflows/​threadx.yml Streamlines the NetXDuo build workflow.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@padelsbach
padelsbach marked this pull request as ready for review October 3, 2026 03:47
@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown

retest this please

@padelsbach
padelsbach requested a balanced review from Copilot October 3, 2026 03:50
@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown

MemBrowse Memory Report

gcc-arm-cortex-m0plus

  • FLASH: .text +192 B (+1.8%, 69,147 B / 262,144 B, total: 26% used)

gcc-arm-cortex-m3

  • FLASH: .text +184 B (+0.9%, 129,133 B / 262,144 B, total: 49% used)

gcc-arm-cortex-m4

  • FLASH: .text +192 B (+0.6%, 207,852 B / 262,144 B, total: 79% used)

gcc-arm-cortex-m4-baremetal

  • FLASH: .text +128 B (+1.6%, 71,523 B / 262,144 B, total: 27% used)

gcc-arm-cortex-m4-crypto-only

  • FLASH: .text +192 B (+0.7%, 180,829 B / 262,144 B, total: 69% used)

gcc-arm-cortex-m4-dtls13

  • FLASH: .rodata +1,024 B, .text +256 B (+0.7%, 192,260 B / 1,048,576 B, total: 18% used)

gcc-arm-cortex-m4-min-ecc

  • FLASH: .text +128 B (+1.8%, 66,309 B / 262,144 B, total: 25% used)

gcc-arm-cortex-m4-openssl-compat

  • FLASH: .rodata +1,024 B, .text +448 B (+0.2%, 790,492 B / 1,048,576 B, total: 75% used)

gcc-arm-cortex-m4-pkcs7

  • FLASH: .text +832 B (+0.8%, 221,598 B / 262,144 B, total: 85% used)

gcc-arm-cortex-m4-pq

  • FLASH: .rodata +1,024 B, .text +320 B (+0.4%, 308,272 B / 1,048,576 B, total: 29% used)

gcc-arm-cortex-m4-rsa-only

  • FLASH: .rodata +1,024 B, .text +384 B (+0.4%, 338,544 B / 1,048,576 B, total: 32% used)

gcc-arm-cortex-m4-sp-math

  • FLASH: .text +128 B (+1.8%, 66,309 B / 262,144 B, total: 25% used)

gcc-arm-cortex-m4-tls12

  • FLASH: .text +192 B (+0.9%, 129,917 B / 262,144 B, total: 50% used)

gcc-arm-cortex-m4-tls13

  • FLASH: .text +256 B (+0.5%, 247,198 B / 262,144 B, total: 94% used)

gcc-arm-cortex-m7

  • FLASH: .text +192 B (+0.6%, 207,852 B / 262,144 B, total: 79% used)

gcc-arm-cortex-m7-pq

  • FLASH: .rodata +1,024 B, .text +256 B (+0.4%, 309,168 B / 1,048,576 B, total: 29% used)

gcc-arm-cortex-m7-tls13

  • FLASH: .text +256 B (+0.5%, 247,198 B / 262,144 B, total: 94% used)

linuxkm-pie

  • Data: __patchable_function_entries +96 B (+0.3%, 28,600 B)

linuxkm-standard

  • Data: __patchable_function_entries +64 B (+0.1%, 51,392 B)

stm32-sim-stm32h753

  • FLASH: .text +1,856 B (+1.0%, 194,964 B / 2,097,152 B, total: 9% used)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused workflow change preserves the existing build while eliminating unnecessary downloads.

Review effort: Balanced
Findings: None

@padelsbach

Copy link
Copy Markdown
Contributor Author

jenkins retest this please

1 similar comment
@padelsbach

Copy link
Copy Markdown
Contributor Author

jenkins retest this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants