Falcon ct hardening - #11639
Open
danielinux wants to merge 4 commits into
Open
Falcon ct hardening#11639danielinux wants to merge 4 commits into
danielinux wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new 32-bit arithmetic paths lack runtime test coverage in the current CI matrix.
Review effort: Balanced
Findings: 1
What changed in this PR
Hardens Falcon floating-point emulation against optimizer-introduced timing branches.
Changes:
- Adds an optimizer-opaque value helper.
- Implements branchless 32-bit shift paths.
- Hardens selections in
fpr_floor,fpr_add, andfpr_mul.
| File | Description |
|---|---|
wolfcrypt/src/falcon.c |
Adds constant-time arithmetic hardening. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Falcon: three constant-time hardening improvements
ca554c4 keep fpr_mul selects branchless
f9dad23 branchless fpr shift helpers on 32-bit targets
e6abd33 keep fpr_add and fpr_floor selects branchless