Repository navigation
Fix/fenrir9929 - #11653
Open
ageprocpp wants to merge 2 commits into
Open
Fix/fenrir9929#11653ageprocpp wants to merge 2 commits into
ageprocpp wants to merge 2 commits into
Conversation
ageprocpp
force-pushed
the
fix/fenrir9929
branch
from
October 6, 2026 05:27
00356ca to
7f6cb06
Compare
ageprocpp
marked this pull request as ready for review
October 6, 2026 05:40
|
retest this please |
|
Member
|
Okay to test. Intern for wolfSSL |
ageprocpp
force-pushed
the
fix/fenrir9929
branch
from
October 6, 2026 17:33
7f6cb06 to
8451160
Compare
Author
|
Will rebase after #11665 is merged |
ageprocpp
force-pushed
the
fix/fenrir9929
branch
from
October 8, 2026 13:34
8451160 to
f4bc2f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes F-9929
wc_Sha256Copy(wc_Sha256* src, wc_Sha256* dst), which copieswc_Sha256instances, lacked error handling when src and dst memories have overlapping.It is unclear if this function should return
BAD_FUNC_ARGon all such opportunity, but implemented that behavior.The same changes to
wc_Sha224Copy.Testing
Did not add any test because the specification does NOT guarantee this function returns BAD_FUNC_ARG and just stipulate that this is an undefined behavior.
(If guaranteeing this returns BAD_FUNC_ARG, we'd have to change all other ad-hoc implementations for a number of environments)
Checklist
Discussion
It is unclear if this function should return BAD_FUNC_ARG when
src == dstbecause it is somehow reasonable expectation for the function to work fine by doing nothing. I would like have reviewers' comments in this respect.It should be noted that src is not const pointer and in some environment the content of src can be changed by this function.