Repository navigation
Conversation
Bumps [sqlparse](https://github.com/andialbrecht/sqlparse) from 0.4.4 to 0.5.0. - [Changelog](https://github.com/andialbrecht/sqlparse/blob/master/CHANGELOG) - [Commits](andialbrecht/sqlparse@0.4.4...0.5.0) --- updated-dependencies: - dependency-name: sqlparse dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Peter Lee <yankeeguyu@gmail.com>
Bumps [gunicorn](https://github.com/benoitc/gunicorn) from 21.2.0 to 22.0.0. - [Release notes](https://github.com/benoitc/gunicorn/releases) - [Commits](benoitc/gunicorn@21.2.0...22.0.0) --- updated-dependencies: - dependency-name: gunicorn dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix(aws-es): fixed es auth * fixed lock * rq v1.16
…ash#6890) This combines the manual steps needed for installing the Python dependencies into a single Makefile target.
This code was supposed to be temporary, and raises an exception if REDASH_MULTI_ORG=true is set.
* consistent rq status naming and handling * test fix * make scheduled and deferred statuses cancelable
Co-authored-by: Peter Lee <yankeeguyu@gmail.com>
Use Webpack configuration for locating this asset in the same way that client/app/index.html does. This code path is when REDASH_MULTI_ORG=true. Co-authored-by: github-actions <github-actions@github.com>
Restore previous functionality. Ensure .env exists before building server. Co-authored-by: github-actions <github-actions@github.com>
The 'codecov-action@v4' requires an organization-level upload token, not a single repo upload token, so we're temporarily downgrading it until we can generate an organization-level upload token. Reference: codecov/codecov-action#1273
Thanks to substantial efforts by @andyundso, the Docker Hub images for pgautoupgrade are now multi-arch (x86_64 and ARM64). :)
* serialize errors * lint fix * cover successful case
This reverts commit bd115e7, as it turns out to be a useful security feature. In order to remove this in a better way, we'll need to replace it with something that provides equivalent functionality.
Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.3 to 3.1.4. - [Release notes](https://github.com/pallets/jinja/releases) - [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst) - [Commits](pallets/jinja@3.1.3...3.1.4) --- updated-dependencies: - dependency-name: jinja2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…antd tooltip if they are defined (getredash#6582)" (getredash#6971) This reverts commit c12d450. This commit did not sort tables properly by schema, then name
Linear Spline Horizontal-Vertical Vertical-Horizontal
As documented in https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-PARAMKEYWORDS Multiple parameters are separated by a space.
* Add ibm-db package to enable DB2 as datasource: * Review poetry format * Added condition on platform for ibm-db, as support is restricted --------- Co-authored-by: nicof38 <nicolas@FB-L-230557.soitec.net> Co-authored-by: Tsuneo Yoshioka <yoshiokatsuneo@gmail.com>
…h#7570) Add support for saving dashboard parameters after clicking the Apply button. Parameters are applied in the following order: URL, dashboard parameters, query parameters. Persist the queued values only when “Done Editing” is clicked, keeping Query and Dashboard editors aligned.
…getredash#7586) * fix(destinations): Handle unicode characters in webhook notifications Previously, webhook notifications would fail if they contained unicode characters in the alert data. This was because the JSON payload was not UTF-8 encoded before being sent. This commit fixes the issue by explicitly encoding the JSON data to UTF-8 and adds a test to verify the fix. * move test function to new file --------- Co-authored-by: gaojingyu <gaojingyu>
chore(yarn): Fix yarn registry for json-with-bigint
Remove hard-coded 'https://' when MULTI_ORG is enabled
* Handle NotSupported exception in refresh_schema - Add NotSupported exception handling to refresh_schema() - Log unsupported datasources at DEBUG level - Avoid error metrics for datasources without schema support * Add test for NotSupported exception handling - Test that NotSupported exceptions are caught and logged at DEBUG level - Verify no warning logs are generated for unsupported datasources * Fix import order (ruff) * Remove test for NotSupported exception handling As suggested by @yoshiokatsuneo, testing logging details for 3 lines of code is excessive and may hurt maintainability. The existing tests already ensure the functionality works correctly.
The Elasticsearch2 query runner was looking for configuration['server'] but BaseHTTPQueryRunner defines the schema field as 'url'. This caused a KeyError that manifested as 'Connection Test Failed: server'. Fixes getredash#7044
Co-authored-by: Tsuneo Yoshioka <yoshiokatsuneo@gmail.com>
MySQL 8.0 changed the server default charset from latin1 to utf8mb4. This aligns Redash's MySQL connector with the modern MySQL defaults. Co-authored-by: Tsuneo Yoshioka <yoshiokatsuneo@gmail.com>
* Aggregate y-value for the same x * Fix styling error by prettier
Co-authored-by: Tsuneo Yoshioka <yoshiokatsuneo@gmail.com>
* Update Python version to 3.13 * Limit scope for supressing warning * Update td-client to 1.5.0 to avoid the warning
* master: (69 commits) Update Python version to 3.13 (getredash#7636) Update plotly.js to 3.3.1, react-pivottable to 0.11.0 (getredash#7634) Add charset option to RDS MySQL datasource (getredash#7616) Aggregate y value for same x (getredash#7631) fix(mysql): Change default charset to utf8mb4 (getredash#7615) Update packages for compatibility with setuptools 82 (getredash#7622) Snapshot: 26.02.0-dev chore: support ipv6 for server in docker (getredash#7596) Add impersonation option in trino datasource (getredash#7605) Fix Elasticsearch connector configuration key mismatch (getredash#7607) duckdb: Show catalog (database) where applicable (e.g. Motherduck) (getredash#7599) Snapshot: 26.01.0-dev Feature/catch notsupported exception (getredash#7573) Multi-org: format base path, not including protocol (getredash#7260) fix(destinations): Handle unicode characters in webhook notifications (getredash#7586) Persist updated values and apply saved dashboard parameters (getredash#7570) Add ibm-db package to enable DB2 as datasource: (getredash#7581) Snapshot: 25.12.0-dev PostgreSQL: allow connection parameters to be specified (getredash#7579) Add lineShape option for Line and Area charts (getredash#7582) ...
![arnica-github-connector[bot]](https://avatars.githubusercontent.com/in/144692?s=60&v=4){kind=small}
| if user is None: | ||
| return logout_and_redirect_to_index() | ||
|
|
||
| return redirect(next_path or url_for("redash.index", org_slug=org_slug), code=302) | ||
|
|
||
|
|
||
| def extract_name(email): |
There was a problem hiding this comment.
Static Code Analysis Risk: Identified pii in python code
Detected the parameter name(s) email inside extract_name
Severity: Info ℹ️
Status: Open 🔴
References:
More details:
For license findings, please review our legal policy: https://wiki.playtika.com/pages/viewpage.action?spaceKey=LEG&title=Open+Source+Code+Usage+Guidelines
Take action by replying with an [arnica] command 💬
Actions
Use [arnica] or [a] to interact with the Arnica bot to acknowledge or dismiss code risks.
To acknowledge the finding as a valid code risk: [arnica] ack <acknowledge additional details>
To dismiss the risk with a reason: [arnica] dismiss <fp|accept|capacity> <dismissal reason>
Examples
-
[arnica] ack This is a valid risk and I'm looking into it -
[arnica] dismiss fp Dismissed - Risk Not Accurate: (i.e. False Positive) -
[arnica] dismiss accept Dismiss - Risk Accepted: Allow the risk to exist in the system -
[arnica] dismiss capacity Dismiss - No Capacity: This will need to wait for a future sprint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
How is this tested?
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)