feat!: Port DirectorySync to oagen

[gjtorikian]

Description

This PR generates the DirecotrySync category in the Node SDK from the OpenAPI spec.

Four methods switched from a positional string argument to an options object:

┌─────────────────┬─────────────────────┬─────────────────────────┐
│     Method      │       Before        │          After          │
├─────────────────┼─────────────────────┼─────────────────────────┤
│ getDirectory    │ getDirectory(id)    │ getDirectory({ id })    │
├─────────────────┼─────────────────────┼─────────────────────────┤
│ deleteDirectory │ deleteDirectory(id) │ deleteDirectory({ id }) │
├─────────────────┼─────────────────────┼─────────────────────────┤
│ getGroup        │ getGroup(group)     │ getGroup({ id })        │
├─────────────────┼─────────────────────┼─────────────────────────┤
│ getUser         │ getUser(user)       │ getUser({ id })         │
└─────────────────┴─────────────────────┴─────────────────────────┘

As well:

1. Timestamps are now Date objects, not strings. createdAt/updatedAt now come back as new Date(...).
2. Directory.state values changed. The previous serializer mapped linked → active and unlinked → inactive. The new serializer passes the raw wire value
   straight through, so getDirectory/listDirectories now return state: 'linked' | 'unlinked' | 'validating' | 'invalid_credentials' | 'deleting'

Because of these changes, this is a major breaking change to the SDK.

[greptile-apps]

Greptile Summary

This PR ports the DirectorySync module to the oagen code generator, migrating four methods from positional string arguments to options objects and replacing the hand-written serializers with generated ones. Two significant behavioral changes land alongside the refactor: createdAt/updatedAt fields across Directory, DirectoryGroup, and DirectoryUserWithGroups are now Date objects, and directory state values now pass through raw wire values ('linked', 'unlinked', …) instead of mapping to the previous 'active'/'inactive' aliases.

• API surface: getDirectory, deleteDirectory, getGroup, and getUser now take { id } options objects; listGroups/listUsers signatures are unchanged.
• Type additions: DirectoryMetadata, DirectoryState, DirectoryType, SlimRole, and related interfaces are now dedicated files generated from the OpenAPI spec.
• Three issues found: GetUserOptions is not re-exported from the public barrel; organizationId is coerced to '' when absent rather than preserving undefined; and the generated DirectoryUserWithGroupsState constant exposes a 'suspended' value that the hand-maintained DirectoryUser.state type does not include.

Confidence Score: 3/5

The core logic is correct but three defects in the generated/hand-maintained layer should be resolved before shipping.

The organizationId ?? '' coercion changes a field that was previously optional to always-present-but-possibly-empty, which is a silent contract break for downstream consumers. GetUserOptions being absent from the barrel means the type is effectively undiscoverable to SDK users. The DirectoryUserWithGroupsState/DirectoryUser.state mismatch means 'suspended' users would be unhandled at the type level. All three touch the public API surface of a major release.

src/directory-sync/serializers/directory.serializer.ts (organizationId coercion), src/directory-sync/interfaces/index.ts (missing GetUserOptions export), src/directory-sync/interfaces/directory-user-with-groups-state.interface.ts (suspended state inconsistency)

Important Files Changed

Filename	Overview
src/directory-sync/directory-sync.ts	Core service class ported to oagen: methods accept options objects instead of raw strings, getGroup is now generated (with encodeURIComponent), and a local serializeListDirectoriesOptions replaces the old shared serializer.
src/directory-sync/serializers/directory.serializer.ts	Simplified serializer with Date conversion; organizationId incorrectly coerced to empty string instead of preserving undefined when absent.
src/directory-sync/interfaces/index.ts	Barrel updated for new interfaces but get-user-options.interface is missing from exports, making GetUserOptions unavailable to public consumers.
src/directory-sync/interfaces/directory-user-with-groups-state.interface.ts	New generated state constant includes 'suspended' which is absent from the hand-maintained DirectoryUser.state type union — inconsistency between generated and hand-owned interfaces.
src/directory-sync/serializers/event-directory.serializer.ts	Moved out of directory.serializer; timestamps remain raw strings while all other entity serializers now produce Date objects — inconsistency across the module.
src/directory-sync/interfaces/directory-group.interface.ts	Timestamps migrated to Date, rawAttributes made optional; clean, consistent with the rest of the PR.
src/directory-sync/interfaces/directory.interface.ts	DirectoryType, DirectoryState, and metadata split into dedicated interfaces; state values now pass raw wire values instead of mapping linked→active/unlinked→inactive; domain made optional.
src/directory-sync/directory-sync.spec.ts	Tests rewritten to use fixture files and helper functions; covers list/get/delete paths including new Date-based timestamp assertions.

Sequence Diagram

%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
    participant Consumer
    participant DirectorySync
    participant WorkOSClient
    participant Serializer

    Consumer->>DirectorySync: "getDirectory({ id })"
    DirectorySync->>WorkOSClient: GET /directories/:id
    WorkOSClient-->>DirectorySync: DirectoryResponse (snake_case, string timestamps)
    DirectorySync->>Serializer: deserializeDirectory(response)
    Serializer-->>DirectorySync: Directory (camelCase, Date timestamps, raw state)
    DirectorySync-->>Consumer: Directory

    Consumer->>DirectorySync: "listDirectories({ organizationId, search })"
    DirectorySync->>DirectorySync: serializeListDirectoriesOptions()
    DirectorySync->>WorkOSClient: "GET /directories?organization_id=..."
    WorkOSClient-->>DirectorySync: "ListResponse<DirectoryResponse>"
    DirectorySync->>Serializer: deserializeDirectory (per item)
    DirectorySync-->>Consumer: "AutoPaginatable<Directory>"

    Consumer->>DirectorySync: "deleteDirectory({ id })"
    DirectorySync->>WorkOSClient: DELETE /directories/:id
    WorkOSClient-->>DirectorySync: 204
    DirectorySync-->>Consumer: void

Loading

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
    participant Consumer
    participant DirectorySync
    participant WorkOSClient
    participant Serializer

    Consumer->>DirectorySync: "getDirectory({ id })"
    DirectorySync->>WorkOSClient: GET /directories/:id
    WorkOSClient-->>DirectorySync: DirectoryResponse (snake_case, string timestamps)
    DirectorySync->>Serializer: deserializeDirectory(response)
    Serializer-->>DirectorySync: Directory (camelCase, Date timestamps, raw state)
    DirectorySync-->>Consumer: Directory

    Consumer->>DirectorySync: "listDirectories({ organizationId, search })"
    DirectorySync->>DirectorySync: serializeListDirectoriesOptions()
    DirectorySync->>WorkOSClient: "GET /directories?organization_id=..."
    WorkOSClient-->>DirectorySync: "ListResponse<DirectoryResponse>"
    DirectorySync->>Serializer: deserializeDirectory (per item)
    DirectorySync-->>Consumer: "AutoPaginatable<Directory>"

    Consumer->>DirectorySync: "deleteDirectory({ id })"
    DirectorySync->>WorkOSClient: DELETE /directories/:id
    WorkOSClient-->>DirectorySync: 204
    DirectorySync-->>Consumer: void

Loading

_{Reviews (1): Last reviewed commit: "Port DirectorySync to oagen" | Re-trigger Greptile}

[greptile-apps]

GetUserOptions missing from public barrel export

GetUserOptions (used as the parameter type for getUser) is not re-exported from the barrel. Every other new options interface introduced in this PR — DeleteDirectoryOptions, DirectorySyncGetGroupOptions, GetDirectoryOptions — is exported, but GetUserOptions is absent. TypeScript consumers who want to explicitly annotate variables or write helper functions around getUser will be unable to import the type from the package's public interface index.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

[greptile-apps]

organizationId coerced to empty string when absent

Directory.organizationId is declared organizationId?: string (optional), so the correct mapping when organization_id is absent is to omit the field or assign undefined. Using ?? '' silently sets it to an empty string instead, which violates the declared type contract. Any consumer checking directory.organizationId === undefined (or using the field as an optional discriminator) will get incorrect behaviour — the field will always be present and truthy except for the empty-string edge case, which is harder to reason about.

Suggested change

	organizationId: response.organization_id ?? '',
	organizationId: response.organization_id ?? undefined,

[greptile-apps]

DirectoryUserWithGroupsState includes 'suspended' but DirectoryUser.state does not

The auto-generated DirectoryUserWithGroupsState constant exports three values — Active, Suspended, and Inactive — implying the wire API can return 'suspended'. However, the hand-maintained DirectoryUser.state type in directory-user.interface.ts is still typed as 'active' | 'inactive'. A directory user whose state is 'suspended' in the provider will carry the value at runtime, but TypeScript consumers trusting the declared union will never expect or handle it. Either the state field in DirectoryUser should include 'suspended', or the generated constant should be reconciled with the hand-owned interface so they don't conflict.

[greptile-apps]

EventDirectory timestamps remain string while all other timestamp fields are now Date

Directory, DirectoryGroup, and DirectoryUserWithGroups all had their createdAt/updatedAt migrated to Date objects in this PR. EventDirectory still assigns raw strings (directory.created_at, directory.updated_at) with no new Date() conversion, and the EventDirectory interface retains createdAt: string. Consumers who process both event and non-event directory objects will now encounter an inconsistent type for the same conceptual field.