feat!: Generate SSO from OpenAPI spec#1633
Draft
gjtorikian wants to merge 3 commits into
Draft
Conversation
Mark deleteConnection, getConnection, getProfileAndToken, and getProfile as hand-owned so oagen preserves their public signatures (positional id args, CustomAttributesType generics, PKCE/confidential-client token exchange) while still owning listConnections and adopting the new logout endpoints. Import deserializeProfileAndToken from its concrete serializer file since the regenerated barrel only re-exports generated serializers, and add the search filter to ListConnectionsOptions for the generated listConnections serializer. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Regenerate SSO with the connection_type wire field surfaced under the domain name `type` (via the new fieldHints), preserving the long-standing public SDK surface; wire serialization still uses connection_type. Drop the redundant hand-written connection-type.enum and point ListConnectionsOptions at the generated connection-type.interface so there is a single ConnectionType. Update the events spec's connection fixture to match. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR generates the SSO logic in the Node SDK from the OpenAPI spec.
Most of the existing methods remained the same, or had new functionality added:
listConnections(options?)optionalsearch?fieldgetAuthorizationUrl,getProfile,getProfileAndToken,getConnection,deleteConnectionremain unchangedgetLogoutUrlandauthorizeLogoutHowever, one field changed:
createdAtandupdatedAtwent from an ISO string to a properDateobject. Because of this, I would recommend this change being a breaking one.