Repository navigation
Add environment-scoped V5 verify endpoint - #2365
igorosip0v wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f9d7aab01b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!isValidRpId(rpId)) { | ||
| return errorResponse({ | ||
| statusCode: 400, | ||
| code: "invalid_rp_id", | ||
| detail: |
There was a problem hiding this comment.
A repo-wide search under web/tests found no V5 verification tests, leaving the new invalid-RP, invalid-environment, body/path mismatch, and path-environment injection branches unexercised. Add a mirrored web/tests/api/v5/... handler suite that covers these distinct outcomes and verifies whether downstream verification is invoked.
AGENTS.md reference: AGENTS.md:L33-L37
Useful? React with 👍 / 👎.
Takaros999
left a comment
Takaros999
left a comment
There was a problem hiding this comment.
introducing a new /verify endpoint adds one more endpoint we need to think about and maintain, the return doesn't seem that high for introducing a new endpoint
This branch was successfully deployed
2 participants
Adds
POST /api/v5/verify/{environment}/{rp_id}. The environment is validated from the URL, then passed to the shared proof-verification flow. A conflictingenvironmentin the request body is rejected. V4 continues to use the body value, or defaults to production when it is omitted.Validation: