Repository navigation
Conversation
|
@Imran2210 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
There was a problem hiding this comment.
The current head cannot be merged because the manifest package no longer typechecks. consumers.ts references undefined CONTRACT_IDS and stellarContractIds symbols, plus a contract.artifact field that is not in the manifest Contract type. The same patch also regresses existing validation: keccak256 was changed to keccakk256, the Solana base58 character class is malformed, and the Stellar contract-id regex now expects 56 characters after C instead of 55. Please keep the existing EVM and Solana schema intact, implement the Stellar consumer against the actual manifest types and constants, and rerun the manifest typecheck and tests.
truthixify
left a comment
There was a problem hiding this comment.
The conflict-resolution update does not clear the blocker: the required Deployment Manifest check still fails. The job reports unresolved manifest code/schema errors including undefined CONTRACT_IDS and stellarContractIds references, contract.artifact access on the current schema, and the keccakk256 typo. Please fix the implementation against current develop and rerun the required check.
truthixify
left a comment
There was a problem hiding this comment.
This conflict-resolution commit still leaves the manifest package uncompilable. The required check continues to report undefined and , access to a nonexistent , and the schema typo that breaks the existing EVM types/tests. Please resolve these against current and rerun the deployment-manifest typecheck and test suite before another review.
truthixify
left a comment
There was a problem hiding this comment.
This conflict-resolution commit still leaves the manifest package uncompilable. The required check continues to report undefined CONTRACT_IDS and stellarContractIds symbols, access to a nonexistent Contract.artifact field, and the keccakk256 schema typo that breaks existing EVM types and tests. Please resolve these against current develop and rerun the deployment-manifest typecheck and test suite.
Dismissed because the review body was corrupted while posting; a corrected review follows.
Overview
This PR records the canonical Stellar testnet deployment in
deployments/manifest.jsonand wires Stellar into the deployment-manifest tooling so the manifest is validated, consumed, and drift-checked like the existing EVM, Solana, and CKB records. It closes the Wave 9 carryover gap where the SDK and docs referenced Stellar testnet addresses that were absent from the canonical manifest.Related Issue
Changes
🌟 Stellar Manifest Record
[ADD]
scripts/deployment-manifest/src/record/stellar.ts[MODIFY]
deployments/manifest.json[MODIFY]
deployments/schema/v1.json🔧 Manifest Tooling
[MODIFY]
scripts/deployment-manifest/src/manifest.ts[MODIFY]
scripts/deployment-manifest/src/consumers.ts[MODIFY]
deployments/README.mdVerification Results
deployments/manifest.jsonwith supported contractsconsumers.tsCloses #230