Skip to content

feat(deployments): require an explicit EVM record for every supported contract - #258

Merged
truthixify merged 1 commit into
wraith-protocol:developfrom
Jerryvic911:issue-231-evm-manifest
Oct 18, 2026
Merged

truthixify merged 1 commit into
wraith-protocol:developfrom
Jerryvic911:issue-231-evm-manifest

Conversation

@Jerryvic911

Copy link
Copy Markdown
Contributor

Closes #231

Completes the EVM deployment manifest contract set (carryover from #188 and #191).

  • Adds an optional undeployed: [{ name, reason }] list to the deployment record schema.
  • horizen-testnet now records ERC5564Announcer and ERC6538Registry, and marks
    WraithSender, WraithNames and WraithWithdrawer as explicitly undeployed.
  • check, build, record and verify fail unless every supported EVM contract is
    either recorded or marked undeployed. A name in both lists, or an unknown name, also fails.
  • Every recorded EVM contract must carry its deployment tx hash, block height,
    artifact hash and ABI hash.
  • record --undeployed Name=reason is added; recording a contract removes it from the list.
  • Other chains are unaffected (EXPLICIT_COVERAGE_CHAINS in catalogue.ts).

Tests: 12 new (unit and e2e), 55 total passing on Linux.

@drips-wave

drips-wave Bot commented Oct 18, 2026

Copy link
Copy Markdown

@Jerryvic911 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@truthixify truthixify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed exact head db3738a: the explicit EVM coverage model matches issue #231, and duplicate/unknown/overlapping states are rejected. Typecheck, all 55 manifest tests, the canonical manifest check, and required GitHub checks pass.

@truthixify
truthixify merged commit 4f6189e into wraith-protocol:develop Oct 18, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Wave 10][Carryover] Complete the EVM deployment manifest contract set

2 participants