Repository navigation
feat: replace history placeholder with shared activity store - #235
legend-esc wants to merge 1 commit into
Conversation
|
@legend-esc is attempting to deploy a commit to the truthixify's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@legend-esc Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
truthixify
left a comment
There was a problem hiding this comment.
This regresses the privacy scoping already present in Activity.tsx. The new History page reads and renders every persisted entry without requiring a connected wallet or filtering by entry.wallet, and its exportEntries value is built from all entries rather than filteredEntries. Switching wallets can therefore reveal and export another wallet/profile's history. Reuse the existing Activity page or preserve its connected-wallet scope, export only the filtered scoped entries after removing metadata, and add cross-wallet isolation tests.
Summary
Replace the
/historyplaceholder ("History coming soon") with a functional activity history page backed by the sharedactivityStore.Changes
src/pages/History.tsx: rewrote to read entries fromuseActivityStore, render each viaActivityRow, and support empty/pending/failed/confirmed states with chain/type/status filters.src/stores/activityStore.ts: addedclearAll()to clear all history entries.src/App.tsx: routed/historytoHistory(previously shared theActivitypage).Details
metadataso private key/memo material is never exposed.Verification
tsc --noEmit: cleanprettier --check: cleanvitest run: 338/338 passingvite build: passingCloses #218