Skip to content

fix: reject non-hex Stellar meta-address payloads - #258

Merged
truthixify merged 1 commit into
wraith-protocol:developfrom
xtrial01:fix/stellar-meta-address-hex-validation
Oct 17, 2026
Merged

truthixify merged 1 commit into
wraith-protocol:developfrom
xtrial01:fix/stellar-meta-address-hex-validation

Conversation

@xtrial01

Copy link
Copy Markdown
Contributor

Summary

Closes #233 by rejecting Stellar meta-address payloads containing non-hexadecimal characters before decoding. Invalid payloads now produce a consistent validation error.

Added table-driven cases and a property test covering invalid characters across all payload positions.

Verification

  • Stellar tests: 1,002 passed, 5 skipped.
  • Package build passed.
  • Prettier passed for both changed files.
  • Full-repository checks have unrelated existing failures: formatting in seven other files, sdk-agent type errors, and workspace test failures involving missing Vue dependencies and compatibility documentation.

@drips-wave

drips-wave Bot commented Oct 17, 2026

Copy link
Copy Markdown

@xtrial01 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@truthixify truthixify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The decoder now rejects non-hex payloads before parsing and all 11 focused tests pass. Approved.

@truthixify
truthixify merged commit acc5ff2 into wraith-protocol:develop Oct 17, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Wave 10][Carryover] Reject non-hex Stellar meta-address payloads

2 participants