Repository navigation
Conversation
|
@Daveamhs16 is attempting to deploy a commit to the truthixify's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The checker is useful, but its CI job currently fails with 62 findings and would leave every PR red. Fix the real internal links, add narrow documented allowlist entries only for external false positives, and link this PR to #160. |
Thanks for the review. I’ll address the failing internal links, keep the allowlist limited to documented external false positives, and link the PR to #160. I’ll push the updates shortly. |
|
Addressed the actionable link-check findings and rebased/merged the latest develop.
|
|
Do not allowlist the 10 remaining failures. Use /status until the status host exists, replace aquarius.fi with https://aqua.network, map Stellar and Solana to /sdk/chains/stellar and /sdk/chains/solana, Nervos to /sdk/chains/ckb, and EVM chains plus Horizen to /sdk/chains/evm. Remove or update the stale Wave 1 CTA. Also reject loopback, private, and link-local destinations before external fetches and after redirects so PR content cannot turn CI into an SSRF probe. |
|
The link fixes and CI pass now, but two blockers remain. The SSRF guard allows IPv4-mapped IPv6 such as http://[::ffff:127.0.0.1]/ and validates DNS separately from fetch, so DNS rebinding can still reach a private address. Normalize mapped addresses, make each request use the validated DNS result through redirects, and add regression tests. Also restore the Terms, audit, bounty, disclosure, and Spectre links with valid destinations instead of removing them to satisfy the checker. |
Thanks for the review. I've restored the Spectre CTAs using the existing roadmap's Spectre milestone and strengthened the SSRF checks. I also verified that the original Terms, audit reports, disclosure log, and security documentation URLs currently return 404 or time out. The existing Security page contains overview sections, but not the underlying reports or disclosure records. Could you confirm the approved destinations for these resources, or whether links to clearly labeled on-site overviews are acceptable temporarily? I want to preserve the functionality without introducing broken or misleading links. |
|
On-site security overviews are fine for now. Link audits, bounty, and disclosures to anchored sections on /security, and restore Spectre to the roadmap milestone. For Terms, add a real /terms page or leave it blocked; do not point it to Privacy. I do not see a new commit yet, and the current head still allows mapped IPv6 and DNS rebinding. Push the SSRF fix with regression tests and I will re-review. |
|
Wave 9 has ended, so this PR is being closed without merging. Thank you for the contribution. |
Summary
Adds a production link checker that validates the built site during CI.
The checker uses the project's existing Playwright, Vite, and Vitest tooling and validates:
The checker is integrated into pull request CI and uploads a link-check report for debugging failures.
Changes
Validation
Existing Link Failures
Running the new checker currently exposes existing broken links in the site:
/press,/terms, and misplaced#comparelinks.These failures were detected by the new checker and were not introduced as part of this implementation.
Repository-wide formatting also reports pre-existing formatting issues outside the files changed by this PR.
CI
Pull request CI now runs the production link checker and uploads the generated link-check report for inspection when failures occur.
Closes #160