Repository navigation
Conversation
) - blogSlugFrom now matches only single-segment /blog/<slug> paths, so /blog/tag/* and /blog/author/* no longer fall into the post branch - isIndexableRoute accepts known tag slugs (derived from blog-manifest tags) and opted-in authors; rejects everything else - resolveRouteMetadata resolves tag/author archives with ogType website and i18n-backed copy; unknown slugs still return null - ogImageSlugFor emits blog-tag-<slug> and blog-author-<id> slugs - listOgImageJobs generates one image job per known tag and opted-in author per locale - blog-manifest.json gains a tags field; gen-blog-manifest.mjs emits it for new posts automatically - ogContent in en/es/pt i18n files extended with entries for all 7 known tags and the lena-vogt author archive - Tests: two new describe blocks (tag archives, author archives) with 23 new tests; stale bypass assertions updated in middleware tests
|
@Escelit Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@Escelit is attempting to deploy a commit to the truthixify's projects Team on Vercel. A member of the Team first needs to authorize it. |
truthixify
left a comment
There was a problem hiding this comment.
The non-indexed tag policy is not fully emitted in the rendered page. In src/pages/Blog.tsx:479, the unknown-tag branch sets only the title; unlike the unknown/opted-out author branch, it does not add <meta name="robots" content="noindex" />. The middleware deliberately bypasses /blog/tag/nonexistent-tag, so the base HTML also has no noindex directive. This leaves an unknown tag archive without the robots policy required by #197.
Please add the noindex directive to the unknown-tag state and cover the rendered unknown tag route in a test. Known tag metadata, sitemap entries, OG generation, and the focused build all passed locally.
Closes #197
/blog/tag/* and /blog/author/* were served by the app but rejected by isIndexableRoute, so they had no sitemap entries and no metadata.
The root cause was that blogSlugFrom matched any /blog/, swallowing tag and author paths before they could be handled.
Policy
Changes
ogImageSlugFor, listOgImageJobs all updated
Tests — 23 new tests; all 105 og-metadata and 67 middleware tests pass. Build generates 99 OG images across 33 routes.