🛡️ Sentinel: [MEDIUM] Fix unredacted stderr in hooks - #654
Conversation
Co-authored-by: wryenmeek <6856065+wryenmeek@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5c56e6f2d3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| import sys | ||
| from typing import Any | ||
|
|
||
| from scripts._redaction import redact_stderr |
There was a problem hiding this comment.
When Copilot invokes the configured python3 scripts/hooks/check_approval_flag.py command in .github/hooks/hooks.json, Python places scripts/hooks rather than the repository root on sys.path, so this new absolute import raises ModuleNotFoundError: No module named 'scripts' before the approval check runs. Add the repo-root bootstrap used by check_mixed_scope.py, or change the hook command to a python3 -m ... invocation, so Edit/Write events remain protected.
AGENTS.md reference: AGENTS.md:L162-L162
Useful? React with 👍 / 👎.
1 participant
🚨 Severity: MEDIUM
💡 Vulnerability: git commands inside hooks leak tokens in stderr.
🎯 Impact: GitHub tokens leaked into CI logs.
🔧 Fix: Wrapped stderr with redact_stderr.
✅ Verification: tests pass.
PR created automatically by Jules for task 11186450059475583761 started by @wryenmeek