Fixes sidebar flashing and rebuilding on every nav click - #463
Open
veejask-41 wants to merge 1 commit into
Open
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #461
The Issue
The documentation sidebar was causing severe performance and user experience problems. Every time a user clicked a link, the browser had to download and parse a massive HTML payload, most of which was just the sidebar itself. This resulted in sluggish page loads and heavy network transfers.
Additionally, there was a visible layout shift (a "flash") on every load: the server would render all sidebar sections expanded, and client-side JavaScript would quickly collapse the inactive ones after the page painted. Finally, because soft navigation wasn't enabled, every click was a hard page reload. This meant users constantly lost their sidebar scroll position and any manually expanded sections whenever they navigated.
A significant portion of the page bloat was caused by developer HTML comments inside the navigation template, which were being duplicated in the final output for every single navigation item. The rest of the bloat came from the server rendering the full navigation trees for every product and every inactive version, only to hide them using CSS.
The Fix
1. Trimming the Payload
2. Eliminating the Visual Flash
3. Enabling Seamless Navigation