Repository navigation
Account for solid angle integral in free-free continuum - #479
Merged
Merged
Conversation
wtbarnes
added
continuum
Ion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #474
Previously, the free-free continuum stated that it was returned integrated over the solid angle. This was not correct as the numerical constant included a per steradian factor. This fixes this issue by simply multiplying the numerical constant by a factor of$4\pi$ such that the actual units are unchanged and adds a note in the docstring to this effect.
This is now consistent with the other continuum methods which are also not per steradian.