Repository navigation
Fix bug in allowing arrays of density into two-photon continuum calculation - #480
Merged
Merged
Conversation
wtbarnes
added
continuum
Ion
wtbarnes
added a commit
that referenced
this pull request
Oct 23, 2026
…on continuum calculation (#481) Co-authored-by: Will Barnes <will.t.barnes@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #475
This fixes a bug in how the density is broadcasted with the level populations array in
Ion.two_photon. This resulted in a problem both for arrays of density greater than 1 and when the couple-density-to-temperature option was used. Both should now work.This PR also does a more careful job of indexing the level populations and the selected energy levels, similar to what is done in the contribution function.