Skip to content

fix(deps): patch vite and MCP server SDK advisories - #1593

Open
xiaolai wants to merge 1 commit into
mainfrom
fix/npm-audit-advisories
Open

xiaolai wants to merge 1 commit into
mainfrom
fix/npm-audit-advisories

Conversation

@xiaolai

@xiaolai xiaolai commented Oct 21, 2026

Copy link
Copy Markdown
Owner

Summary

npm advisories published on 2026-10-21 turned the required frontend check red (the Security audit step in fe-static) on every open PR, including #1592. This PR patches what can be patched. The two advisories with no usable fix yet are added to the reviewed baseline, each with the reason it is unreachable in the shipped app.

Policy Gates (Required)

  • This PR is single-focus (one issue, one problem, one objective).
  • This PR includes 100% test coverage for changed behavior and changed code paths. (Dependency and baseline change only; the gate and its tests are unchanged.)
  • If this is a bug fix, the linked issue contains detailed reproduction context. (No issue; the failing CI log is the reproduction.)

Linked Issue

Type of Change

  • Bug fix
  • Feature
  • Docs
  • Refactor
  • Test-only
  • Other (dependency security)

What Changed

  • package.json overrides:
  • scripts/npm-audit-baseline.json:
    • The three launch-editor ids remain only for the vite@5 that website>vitepress 1.x requires. No patched 5.x release exists, and it is reached only by the website dev server.
    • markdown-it GHSA-gfr2-rv44-r23c: the fix, 14.3.3, is still inside the minimumReleaseAge window, which ends 2026-10-23. markdown-it is not imported by the app or server/mcp. Once the window passes, raise the override and delete this entry. The two-way gate fails when the advisory clears, so the entry cannot be forgotten.

Validation

  • I ran pnpm check:all locally (exit 0).
  • node scripts/check-npm-audit.mjs → "every advisory is reviewed and still current".
  • check-npm-audit, check-supply-chain-pins and check-scripts-parity tests pass (80/80).
  • I manually verified critical flows.

PR Checklist

  • The PR avoids unrelated refactors or cleanup.
  • The issue context is clear (linked issue or explanation above).
  • Docs/changelog were updated if behavior or usage changed. (Not applicable.)
  • I am ready to address review feedback.

Advisories published on 2026-10-21 turned the required npm-audit step red
on every open PR.

- Override vite@7 to >=7.3.7 and vite@8 to >=8.3.4 (launch-editor fixes),
  and @modelcontextprotocol/server to >=2.3.1 (transport isolation,
  validation memory, bearer audience).
- Baseline the three launch-editor ids for the vite@5 that
  website>vitepress still needs. VitePress 1.x requires vite 5, and no
  patched 5.x release exists. It is reached only by the website dev server.
- Baseline markdown-it GHSA-gfr2-rv44-r23c. The fix (14.3.3) is still
  inside the minimumReleaseAge window, and markdown-it is only reached
  through the website build and the developer-mode content server. The
  two-way gate fails once the advisory clears, which forces removal.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant