Repository navigation
fix(datasources): block queries through disabled sources - #36
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A persisted status=0 datasource could still create/reuse a pool and execute business queries. Check the current stored status before every shared pool lookup, including stale source objects and cached pools, and reject disabled sources with DATASOURCE_DISABLED/403. Normal dataset discovery now excludes datasets whose source is disabled; administrator discovery and explicit connection diagnostics remain available.
Profiling preserves the disabled error through both sample and range fallback paths, including when a source is disabled during an in-flight sample. Queries already running are not cancelled; subsequent guarded operations are denied. Re-enabling a source restores access. Extract the small pool guard/helper to keep the existing architecture size baseline unchanged.
Validation: initially reproduced 9 failures, then added/reproduced the in-flight profiling regression found during review; all 11 new regressions pass. Full npm test: 514 tests, 502 passed, 12 optional skips, 0 failures. npm run lint: 0 errors / 7 existing warnings; npm run eval: 8/8 fixtures, 2 L3 judgments pending. Independent task review and broad integration review approved. Parent independently reran the 11 regressions. Tests use real in-memory platform metadata and fake business pools without accessing an external business database; PR CI runs the real PostgreSQL/browser/Docker acceptance suites.