Repository navigation
fix(ui): wiring audit — drop fix_review title, guard soft-stop, expose bulk-approve - #157
Merged
xmiksay merged 1 commit intoJul 3, 2026
Conversation
…e bulk-approve What: - NewTaskModal/api types: remove the `title` field from the `fix_review` trigger; the input had no backend counterpart (serde dropped it silently). Hide the Title input for fix_review and trim the empty ": title" from its TriggerView headline. - useTaskDetail.stopAgent: guard on `wsConnected` and warn via alert when the socket is down, instead of a dead Stop click that stream.send no-ops. - AuthRequestsQueue: expose bulk "Approve all" alongside "Deny all", behind an explicit confirm (generalize denyAll → resolveAll(decision)). - Cleanups: drop the dead `resolve()` action from the authRequests store; add the `created_at` field the backend returns to the `TaskResult` type; only reload `detail` in tasks.kill() when it's the task on screen. Why: - Operator filled a Title for fix_review that had no effect; a soft Stop during a WS outage silently did nothing; the bulk-approve capability was unexposed; and a list-row pause clobbered the shown task's detail with an extra fetch. How: - Frontend-only + docs. Tests: tasks.kill() reload scoping (new store test), stopAgent WS guard (two useTaskDetail cases). Architecture doc updated for the Approve-all wiring. Closes #153
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the minor items from the UI wiring audit (#153). Wiring was otherwise complete and healthy — these are the four flagged gaps.
U1 —
fix_reviewtitle dropped silentlyThe New Task modal sent a
titleforfix_reviewthat the backendFixReviewvariant has no field for, so serde silently ignored it. Removedtitlefrom thefix_reviewtrigger type + payload, hid the Title input for that variant, and trimmed the now-always-empty": title"from itsTriggerViewheadline.U2 —
stopAgentno-ops during a WS outagestream.sendno-ops when the socket is closed, so a Stop click during an outage did nothing with no feedback.stopAgentnow guards onwsConnectedand warns the operator to use Pause (hard REST kill) instead.U3 — bulk-approve unexposed
POST /api/auth_requests/bulk_resolveacceptsdecision: "approve"but the queue only offered "Deny all". Added an Approve all button behind an explicit confirm (generalizeddenyAll→resolveAll(decision)).U4 — cleanups
resolve()action from theauthRequestsstore (no caller — the real path isAuthApprovalForm → authApi.resolve).created_atfield the backendtask_sessions::Modelreturns to theTaskResultfrontend type.tasks.kill()now reloadsdetailonly when it's the task on screen, so a list-row pause doesn't clobber the shown task with an extra fetch.Tests
stores/tasks.test.ts:kill()reload scoping (shown task vs list-row vs no detail).useTaskDetailcases:stopAgentwarns-and-no-ops when the WS is down, sends when connected.npm run typecheck+ full vitest suite (82) green.Frontend + docs only; the architecture doc's
bulk_resolverows now mention Approve all.Closes #153