Skip to content

fix(docs): keep group chat searches on the conversation guide - #4463

Merged
neekolas merged 1 commit into
self-hostedfrom
codex/fix-docs-group-search
Oct 7, 2026
Merged

neekolas merged 1 commit into
self-hostedfrom
codex/fix-docs-group-search

Conversation

@neekolas

@neekolas neekolas commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

The composed-site check on #4459 fails because group chat puts the longer Groups guide before Conversations and group chats. The Conversations guide owns group creation. Keep it first for this general query by increasing the shared guide-title search weight from 20 to 100. Keep the existing search assertions.

On the #4459 search index, the old scores were 33.7465 for Groups and 33.6787 for Conversations. With this change they are 162.8672 for Groups and 162.9208 for Conversations. All nine existing search cases retain their expected first result. Specific queries for group permissions, group metadata, and attachment still return their own guides.

Validation:

This PR targets self-hosted and leaves #4459 unchanged. After this fix merges, #4459 must receive the updated base and push a new head so its checks test a new merge commit. A rerun of its current failed job would use the old merge commit.

Note

Raise guide-title search weight from 20 to 100 in docs search config

Updates the search ranking in search-config.mjs so guide-title matches rank above repeated term matches in longer guide bodies. This keeps group chat searches landing on the conversation guide. Risk: guide-title matches now dominate rankings, which may push other guide matches down.

Macroscope summarized 1cc42bb.

@neekolas
neekolas requested a review from a team as a code owner October 7, 2026 15:44
@macroscopeapp

macroscopeapp Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This is a narrowly scoped documentation search-ranking adjustment with existing search coverage and no SDK or backend impact. The docs build/deployment workflow was still running and a repository advisory check was failing, so those results need completion or triage before approval.

You can add or adjust custom eligibility rules. Learn more.

@neekolas
neekolas merged commit ad6255c into self-hosted Oct 7, 2026
49 of 51 checks passed
@neekolas
neekolas deleted the codex/fix-docs-group-search branch October 7, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant