Repository navigation
fix(docs): keep group chat searches on the conversation guide - #4463
Merged
Merged
Conversation
Contributor
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This is a narrowly scoped documentation search-ranking adjustment with existing search coverage and no SDK or backend impact. The docs build/deployment workflow was still running and a repository advisory check was failing, so those results need completion or triage before approval. You can add or adjust custom eligibility rules. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The composed-site check on #4459 fails because
group chatputs the longer Groups guide before Conversations and group chats. The Conversations guide owns group creation. Keep it first for this general query by increasing the shared guide-title search weight from 20 to 100. Keep the existing search assertions.On the #4459 search index, the old scores were 33.7465 for Groups and 33.6787 for Conversations. With this change they are 162.8672 for Groups and 162.9208 for Conversations. All nine existing search cases retain their expected first result. Specific queries for
group permissions,group metadata, andattachmentstill return their own guides.Validation:
This PR targets
self-hostedand leaves #4459 unchanged. After this fix merges, #4459 must receive the updated base and push a new head so its checks test a new merge commit. A rerun of its current failed job would use the old merge commit.Note
Raise guide-title search weight from 20 to 100 in docs search config
Updates the search ranking in search-config.mjs so guide-title matches rank above repeated term matches in longer guide bodies. This keeps group chat searches landing on the conversation guide. Risk: guide-title matches now dominate rankings, which may push other guide matches down.
Macroscope summarized 1cc42bb.