Repository navigation
fix(dev): validate sandbox before registering provider keys - #4754
Merged
Merged
Conversation
Contributor
ApprovabilityVerdict: Needs Human Approval Macroscope's review found this PR requires human approval — This is a focused development-wrapper fix that validates the sandbox before changing network policy or registering provider credentials. Because it changes API-key and secret-handling behavior, the credential path requires human review. You can add or adjust custom eligibility rules. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standalone
sandbox keycould register a provider credential for a same-name VM thatstartwould reject. Validate the VM in the shared key-registration helper before changing network policy or prompting for the secret.Extend the manual regression matrix to reject unexpected agents, kits, and host mounts on this path. Tests remain outside CI discovery.
Follow-up to #4753 and its key-validation review comment.
Validation:
40fbfa3fe9: passed with no findings.Note
Validate sandbox before registering provider keys in
dev/sbx/sandboxregister_keynow callscheck_vmbefore building the secret env var, allowing network access, or prompting for the API key. If the check fails, those later steps are skipped.Macroscope summarized 40fbfa3.