Skip to content

add compress function && update clean function#3

Open
yyt030 wants to merge 2 commits into
xuri:masterfrom
yyt030:master
Open

add compress function && update clean function#3
yyt030 wants to merge 2 commits into
xuri:masterfrom
yyt030:master

Conversation

@yyt030

@yyt030 yyt030 commented Nov 7, 2018

Copy link
Copy Markdown

No description provided.

Comment thread glc.go
Comment thread glc.go
sfb := bufio.NewReader(sf)

df, err := os.OpenFile(filepath.Join(c.path, dest), os.O_WRONLY|os.O_APPEND|os.O_CREATE, 0644)
defer df.Close()

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should check returned error before deferring df.Close()

@codecov

codecov Bot commented Nov 7, 2018

Copy link
Copy Markdown

Codecov Report

Merging #3 into master will decrease coverage by 36.93%.
The diff coverage is 25%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #3       +/-   ##
===========================================
- Coverage   85.71%   48.78%   -36.94%     
===========================================
  Files           1        1               
  Lines          42       82       +40     
===========================================
+ Hits           36       40        +4     
- Misses          4       37       +33     
- Partials        2        5        +3
Impacted Files Coverage Δ
glc.go 48.78% <25%> (-36.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ac2200...5ecf6c4. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants