Repository navigation
Feature: add httpx2 support with httpx fallback #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
6f0f189
feat: support httpx2 backend when available
CoderJoshDK 2e71ec3
docs: prefer httpx2
CoderJoshDK 7dfc80f
test: with httpx
CoderJoshDK 624c9d4
chore: include httpx2 in codegen group
CoderJoshDK d54bb4d
Merge master into httpx2
CoderJoshDK 01a7e51
feat: GITHUBKIT_HTTPX2_DISABLE_FLAG option
CoderJoshDK ff47cb7
docs: admonition block for httpx2 notes
CoderJoshDK 3aad53c
docs: githubkit is lowercase
CoderJoshDK File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| import os | ||
| from typing import TYPE_CHECKING | ||
| import warnings | ||
|
|
||
| GITHUBKIT_HTTPX2_DISABLE_FLAG = "GITHUBKIT_HTTPX2_DISABLE_FLAG" | ||
|
|
||
| if TYPE_CHECKING: | ||
| from hishel.httpx2 import AsyncCacheTransport as AsyncCacheTransport | ||
| from hishel.httpx2 import SyncCacheTransport as SyncCacheTransport | ||
| import httpx2 as httpx | ||
| else: | ||
| httpx = None | ||
| if not os.getenv(GITHUBKIT_HTTPX2_DISABLE_FLAG): | ||
| try: | ||
| from hishel.httpx2 import AsyncCacheTransport, SyncCacheTransport | ||
| import httpx2 as httpx | ||
| except ImportError: | ||
| # Hishel wraps a missing HTTP client in ImportError. | ||
| pass | ||
|
|
||
| if httpx is None: | ||
| try: | ||
| from hishel.httpx import AsyncCacheTransport as AsyncCacheTransport | ||
| from hishel.httpx import SyncCacheTransport as SyncCacheTransport | ||
| import httpx as httpx | ||
| except ImportError: | ||
| raise RuntimeError( | ||
| "GitHubKit requires httpx2 and its Hishel integration " | ||
| "to be installed.\n" | ||
| "You can install them with:\n" | ||
| ' $ pip install httpx2 "hishel[async,httpx2]>=1.4.0"\n' | ||
| ) from None | ||
| else: | ||
| warnings.warn( | ||
| "Using `httpx` with GitHubKit is deprecated; install `httpx2` " | ||
| "and `hishel[async,httpx2]>=1.4.0` instead.", | ||
| DeprecationWarning, | ||
| stacklevel=2, | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| import re | ||
|
|
||
| import httpx | ||
| from githubkit._httpx import httpx | ||
|
|
||
| APP_ROUTES = { | ||
| r"/app", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.