Conversation
Adds railstb+widener/railslr+widener/frame+widener/tightframe+widener framing types to the panelize dialog. Selecting one exposes dedicated Widenercorners/Widenerwidth/Widenerlength/Widenergap fields, which get collapsed into the generic type=plugin/code/arg form (pointing at kibot.panelize_plugins.rail_widener.RailWidenerFramingPlugin) during preset resolution, so the actual panelization code is untouched.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #930
Summary
Adds dedicated pcbnew panelize-dialog fields for KiBot's rail widener framing plugin (see INTI-CMNB/KiBot#953, implemented in INTI-CMNB/KiBot#954).
typechoices withrailstb+widener/railslr+widener/frame+widener/tightframe+widener.Code/Argboxes for dedicatedWidenercorners/Widenerwidth/Widenerlength/Widenergapfields.ppFraming()collapses those synthetic fields into the existingtype: plugin/code/argform during preset resolution (codepointed atkibot.panelize_plugins.rail_widener.RailWidenerFramingPlugin,argbuilt from the widener fields), so the rest of the panelize/plugin-loading pipeline is untouched.kikit/panelize_ui_sections.pychanges; no changes to the actual panelization logic.Dependency: this only makes sense once KiBot's rail widener PR (INTI-CMNB/KiBot#954) is merged and released, since the generated
argreferences that module path. Please don't merge this before that lands.Test plan
ppFraming()resolves arailstb+widenersection (withwidenercorners/widenerwidth/widenerlength/widenergap) intotype: plugin+ the correctcodeclass object +argJSON (units correctly converted to KiCad native IU, matching whatwidth/filletresolve to in the same section).