Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verified source-path security risk
PR #5's
backend/app/reporting/sarif.py::_safe_pathrejects traversal, absolute paths and controls but does not apply the repository'scontains_secretsdetector to evidence paths. The SARIF builder then writes the URI returned by_safe_pathintoartifactLocation.uri. A canonically attested repository filename containing a recognizable token pattern (for example a syntheticghp_-shaped filename) can therefore be serialized into the downloadable SARIF artifact. The existingis_canonical_confirmed_findingattestation check verifies provenance, not secret-free filenames. This is a confirmed code-path risk; no actual credential exposure has been observed.Minimal change
app.security.redaction.contains_secretsin_safe_pathto omit a finding with a credential-shaped evidence path rather than output a redacted/invalid URI.Validation / review required
main. Do not auto-merge or deploy.