Skip to content

fix(sarif): restore importability after escaped-quote regex change - #17

Draft
yashaskn8 wants to merge 2 commits into
feature/verified-sarif-export-2026from
fix/sarif5-quoted-regex-syntax-20261101
Draft

yashaskn8 wants to merge 2 commits into
feature/verified-sarif-export-2026from
fix/sarif5-quoted-regex-syntax-20261101

Conversation

@yashaskn8

Copy link
Copy Markdown
Owner

Confirmed regression

The latest PR #5 commit b803b991124b introduces an invalid Python raw double-quoted string literal in backend/app/reporting/sarif.py at line 33. CI run 41293022703 on November 1, 2026 confirms SyntaxError: invalid syntax in the backend bytecode compilation step and the Windows test import, blocking all backend tests and SARIF imports. The frontend's 14 failures are separate and previously observed.

Minimal fix

  • Use a raw triple-double-quoted string for the affected regex alternative so both single- and double-quoted credential patterns remain syntactically valid without changing their regex semantics.
  • Add a focused regression test requiring complete redaction of synthetic quoted assignments containing escaped quote characters, including the suffix after the escape.

Verification and safety

  • Source and GitHub-hosted CI logs inspected. The new test has not been executed; require focused backend tests, full CI (including Windows), and independent human review before integration.
  • Draft PR stacked on PR feat: verified SARIF export for completed scans #5's feature branch, not main. Do not auto-merge, deploy, publish SARIF, run untrusted repository code, or expose secrets. No actual credential exposure observed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant