Reset cursor result state before each query - #46
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues remain, and regression coverage is included.
Pull request overview
Resets cursor result state before each query to prevent stale rows and metadata from leaking between executions.
Changes:
- Adds shared reset logic for synchronous and asynchronous cursors.
- Adds regression tests for unread, consumed, and no-result queries.
File summaries
| File | Description |
|---|---|
ydb_dbapi/cursors.py |
Resets buffered rows, row count, and description before queries. |
tests/test_cursors.py |
Adds synchronous and asynchronous regression coverage. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45.
Reset buffered cursor rows, row count, and description whenever a new query
begins. This prevents unread rows from a previous operation from being
returned by a later execute call and keeps result metadata scoped to the
latest operation.
Add synchronous and asynchronous regression coverage for unread results,
consumed row counts, and statements without result columns.