Conversation
When a coroutine yields an exception out of `retry_operation` using `YdbRetryOperationFinalResult.exc`, a reference to the exception is retained in `result.exc` after it gets raised. When dealing with exceptions that don't participate fully in cyclic garbage collection (such as Pydantic's `ValidationError` underlying a custom error), this reference cycle (`YdbRetryOperationFinalResult` -> `Exception` -> traceback -> generator frame -> locals -> `YdbRetryOperationFinalResult`) causes coroutine local objects (payloads) to stay alive in memory. This change avoids retaining the reference to the completed exception object within the generator frame once it is re-raised, fixing the memory leak. A memory leak regression test was also added reflecting a complex chained exception scenario. Co-authored-by: makhalin <2647652+makhalin@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #906 +/- ##
=======================================
Coverage ? 82.66%
=======================================
Files ? 99
Lines ? 12953
Branches ? 1268
=======================================
Hits ? 10708
Misses ? 1793
Partials ? 452
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
LuckySting
approved these changes
Sep 28, 2026
vgvoleg
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a coroutine yields an exception out of
retry_operationusingYdbRetryOperationFinalResult.exc, a reference to the exception is retained inresult.excafter it gets raised. When dealing with exceptions that don't participate fully in cyclic garbage collection (such as Pydantic'sValidationErrorunderlying a custom error), this reference cycle (YdbRetryOperationFinalResult->Exception-> traceback -> generator frame -> locals ->YdbRetryOperationFinalResult) causes coroutine local objects (payloads) to stay alive in memory.This change avoids retaining the reference to the completed exception object within the generator frame once it is re-raised, fixing the memory leak. A memory leak regression test was also added reflecting a complex chained exception scenario.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #905
What is the new behavior?
Other information