Support SQLAlchemy 1.4 across the dialect - #121
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The compatibility changes are consistently implemented, documented, and covered by version-specific unit and integration suites.
Pull request overview
Adds comprehensive SQLAlchemy 1.4 compatibility while preserving SQLAlchemy 2.0 behavior.
Changes:
- Backports compiler, literal, bind-type, and transaction compatibility.
- Runs unit and integration suites against pinned 1.4 and 2.0 releases.
- Updates compatibility documentation and release notes.
File summaries
| File | Description |
|---|---|
ydb_sqlalchemy/sqlalchemy/test_sqlalchemy.py |
Expands compiler and type tests. |
ydb_sqlalchemy/sqlalchemy/datetime_types.py |
Adds portable datetime literal rendering. |
ydb_sqlalchemy/sqlalchemy/compiler/sa14.py |
Implements missing 1.4 compiler behavior. |
ydb_sqlalchemy/sqlalchemy/compiler/base.py |
Improves bind-type inference and nullable handling. |
tox.ini |
Adds pinned SQLAlchemy 1.4 environments. |
tests/integration/test_suite.py |
Adapts compliance tests for both versions. |
tests/integration/test_core.py |
Updates transaction and query compatibility tests. |
tests/integration/test_alembic.py |
Makes commit behavior compatible with 1.4. |
test-requirements.txt |
Moves SQLAlchemy pinning into tox. |
docs/installation.rst |
Documents supported release lines. |
docs/index.rst |
Updates compatibility overview. |
CHANGELOG.md |
Records SQLAlchemy 1.4 support. |
.github/workflows/tests.yml |
Runs both version suites in CI. |
Review details
- Files reviewed: 13/13 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add full SQLAlchemy 1.4 compatibility across compiler behavior, datetime literals, transactions, and dialect-specific tests.
Pin the tested SQLAlchemy releases in separate tox environments and run both unit and full dialect suites for 1.4 and 2.0 in CI. Update the documentation to describe both supported release lines.