Expand SQLAlchemy dialect test coverage - #122
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
All reviewed changes are covered and no blocking issues were identified.
Pull request overview
Expands SQLAlchemy compliance and integration coverage for supported YDB features across sync and async backends.
Changes:
- Enables supported conditional DDL, boolean, tuple
IN, and window-function tests. - Narrows unsupported numeric and SQLAlchemy exclusions.
- Adds inspection, container, concatenation, decimal, scalar-subquery, and view-reflection coverage.
File summaries
| File | Description |
|---|---|
ydb_sqlalchemy/sqlalchemy/requirements.py |
Enables supported SQLAlchemy capabilities. |
tests/integration/test_suite.py |
Expands compliance and custom suite coverage. |
tests/integration/test_inspect.py |
Adds view reflection coverage. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable SQLAlchemy compliance coverage for YDB capabilities that are already supported, including conditional table DDL, boolean expressions, tuple IN, window functions, scalar subqueries, and numeric reflection.
Collect the custom inspection, container, concatenation, and decimal suites for both sync and async backends. Replace broad numeric and SQLAlchemy 1.4 exclusions with targeted skips for the remaining unsupported cases, and cover basic YDB view reflection separately from SQLAlchemy's unsupported multi-reflection semantics.