[yeonie0309]

📌 PR 설명

• 여행 기록 등록, 수정의 스티커 검증을 사진 이동 전에 수행
• 검증 실패 후 같은 임시 사진, 원래 버전으로 재시도 가능하도록 보완

🔗 연관된 이슈

Resolves: #426

📝 리뷰 요구사항

• [Feat] 여행 기록 공동 편집 및 수정 충돌 방지 구현 #421 리뷰에서 요청받은 후속 보완입니다.
• [Feat] 여행 기록 삭제 및 공유 앨범 나가기 구현 #423 머지 완료 후 base를 develop으로 변경했습니다.

💻 테스트 결과

• 전체 테스트 및 빌드 통과
• 로컬 Swagger, MySQL 정상 동작 확인

등록 스티커 검증 실패

수정 스티커 검증 실패

원래 버전으로 정상 수정

Summary by CodeRabbit

• Bug Fixes
  • Travel records now reject stickers that are unavailable, belong to another user, have been deleted, or use duplicate layer positions.
  • When sticker validation fails, temporary photos remain available, and failed record changes are not saved.
  • You can correct sticker issues and retry using the same temporary photos.
  • Updating a record without providing a sticker list preserves its existing stickers; submitting an empty list removes them.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: e7abd8a7-f970-403d-b3d4-4d268c246261

Commits

Reviewing files that changed from the base of the PR and between 42409ad and 8f0b6ba.

Files selected for processing: 2

• src/main/java/com/yeogido/backend/domain/travel/service/TravelRecordServiceImpl.java
• src/test/java/com/yeogido/backend/domain/travel/service/TravelRecordStickerValidationTransactionTest.java

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

Travel-record creation and update now validate sticker requests and prepare the available-sticker map before moving images. Integration tests cover invalid requests, retry behavior, and the different effects of null and empty sticker lists.

Changes: Travel record sticker validation

Layer / File(s)	Summary
Validate stickers before image movement src/main/java/com/yeogido/backend/domain/travel/service/TravelRecordServiceImpl.java, src/test/java/com/yeogido/backend/domain/travel/service/TravelRecordStickerValidationTransactionTest.java	Creation and update prepare sticker data before moving images. Update retains existing stickers when the request is null and removes them when the list is empty. Integration tests check validation failures, preserved state, and successful retries using the same temporary photo.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix · Severity of issue fixed: Medium

Possibly related PRs

• yeogido/backend#421: This PR changes sticker validation in the version-checked update flow introduced by PR #421.

Suggested reviewers: yangjiae12

Merge Risk: Minimal · up to 8f0b6

The intended validation order is in place, with no identified issue requiring a fix before merge.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title clearly describes preventing temporary photo consumption when travel-record sticker validation fails. It matches the main change.
Description check		The description includes the change summary, linked issue, review notes, test results, and validation evidence. It is complete enough for the repository template.
Linked Issues check		[#426] The create path resolves and validates stickers, checks sticker availability, and only then calls moveImages. The update path reserves the version, validates stickers against the existing pla…
Out of Scope Changes check		The whole-PR diff changes TravelRecordServiceImpl and adds TravelRecordStickerValidationTransactionTest. The service changes move sticker validation before photo movement and reuse the validated s…
Docstring Coverage		Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…

Full details: Linked Issues check

Explanation

[#426] The create path resolves and validates stickers, checks sticker availability, and only then calls moveImages. The update path reserves the version, validates stickers against the existing placement, and only then calls moveImages. Transactional rollback restores the reserved version and existing data when validation fails. TravelRecordStickerValidationTransactionTest verifies no photo move on missing, foreign, deleted, or duplicate-zIndex stickers. It also verifies retry with the same temporary photo and original version. The test covers omitted stickers and empty-list deletion. The existing update helper behavior for retained stickers remains unchanged.

Full details: Out of Scope Changes check

Explanation

The whole-PR diff changes TravelRecordServiceImpl and adds TravelRecordStickerValidationTransactionTest. The service changes move sticker validation before photo movement and reuse the validated sticker map. The test covers rollback, retry, validation errors, and sticker-list policies required by [#426]. No unrelated product behavior or unrelated refactoring appears.

Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 7 functions across 2 files.

Finishing Touches

Generate docstrings

• Commit to this branch
• Create a new PR

Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[yeonie0309]

@coderabbitai review

[coderabbitai]

Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[yangjiae12]

이전에 말씀드린 부분 반영된 거 확인했습니다! 수고하셨습니다~