Continuations cleanup: docs, comments, and regression tests#714
Merged
MauroToscano merged 1 commit intoJun 25, 2026
Merged
Conversation
Keep the follow-up scoped to non-performance cleanup while preserving the soundness regression coverage. - Add L2G/global-memory regression tests for MU selector behavior, chain truncation, l2g-root binding, and private-input continuations. - Fix stale continuation/global-memory docs and comments. - Replace bare x254 byte address literals with register_base_address(254). - Remove the unused DEFAULT_EPOCH_SIZE constant and document run_epochs as a test/bench helper.
973a14c to
2bddaff
Compare
|
Benchmark Results for unmodified programs 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up cleanup on top of #685 (continuations), targeting the
continuations-local-to-globalbranch so it can be folded into the PR.This version intentionally leaves the performance changes out so they can be rechecked separately.
Soundness-regression tests
The production code is correct today; these guard against silent regressions of the main continuation properties:
MUselector —MU=0on a touched row,MU=1on padding, andMU=2non-boolean are each rejected.MU=0on a later epoch's row) is rejected.init_epoch < fini_epochordering arithmetic for self/future references.EpochProof.l2g_rootis rejected, covering the epoch-to-global L2G root binding.Cleanup
508literals withregister_base_address(254).DEFAULT_EPOCH_SIZE; noterun_epochsas a test/bench helper.page_configsbundle field from design section 8, register the design doc inSUMMARY.md, and correct theglobal_memorycolumn table.Verification
make lintcargo test --release -p lambda-vm-prover local_to_global_bus_testscargo test --release -p lambda-vm-prover test_split_verify_rejects_tampered_l2g_rootDeferred
--num-epochscycle counting.from_image_and_logs.