Avoid duplicate L2G trace work in continuations#719
Open
MauroToscano wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build_traces; the continuation driver now installs the real provenance-aware boundary trace.epoch_touched_cellsavailable for tests/helpers, but remove it from the hot continuation proving loop.Rationale
The continuation prover was replaying each epoch's logs once to collect touched cells, then replaying them again to build traces. The trace build already has the final
MemoryState, so it can expose the sparse touched-cell set directly.build_tracesalso generated an L2G trace that production immediately overwrote with the cross-epoch provenance-aware boundary. This PR avoids that dead work and leaves L2G construction to the continuation driver.Verification
cargo fmt --allmake compile-programs-asm CLANG=/opt/homebrew/opt/llvm/bin/clangcargo test -p lambda-vm-prover continuation -- --nocapturecargo test -p lambda-vm-prover local_to_global -- --nocapturemake lint