Keep default values out of global option help#41
Merged
carldebilly merged 2 commits intoJun 26, 2026
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f044b58450
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Contributor
Author
|
Updated after Codex review: |
8f9f94b
into
yllibed:dev/cdb/issue-33-global-option-help
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses review feedback on #34 by keeping the PR scoped to global option descriptions in help output, without introducing default-value rendering.
[default: ...]rendering from root global option help.false,0, etc.) from being stored as registration defaults, so caller fallbacks still work for value-typed globals.AddGlobalOption(...)overloads remain, and description-capable overloads are additive.Follow-up
Created #40 for a dedicated design/implementation of global option default-value rendering, including
[DefaultValue]support.Validation
dotnet test src/Repl.Tests/Repl.Tests.csproj -c Release --filter 'FullyQualifiedName~Given_GlobalOptionsAccessor'— 40 passeddotnet test src/Repl.IntegrationTests/Repl.IntegrationTests.csproj -c Release --filter 'FullyQualifiedName~Given_CustomGlobalOptions'— 5 passeddotnet build src/Repl.slnx -c Release -warnaserror --no-restore— 0 warnings/errorsdotnet test src/Repl.slnx -c Release— 982 passednpx -y markdownlint-cli2 '**/*.md'— 0 errorsgit diff --check