Repository navigation
Keep healthy queue messages processing when blob payloads are missing - #16
Open
Yan Mahdych (ymahdych) wants to merge 3 commits into
Open
Yan Mahdych (ymahdych) wants to merge 3 commits into
Yan Mahdych (ymahdych) wants to merge 3 commits into
Conversation
Delete main-queue messages whose payload returns 404 BlobNotFound, including during transfer to quarantine, so healthy messages in the same receive batch can continue processing. Preserve handling of other storage errors and quarantine reads. Add five regression cases to MessageQueueTests. Verified all 19 MessageQueueTests against local Azurite.
Record blob and queue-message identities across upload, send, receive, update, quarantine and deletion to investigate missing payloads and shared references. Correlate logical sends with operation and Azure request IDs, and record blob ETags and deletion results. Move existing MessageQueue and TimerBatch events to source-generated ILogger extensions while preserving their templates, levels and fields. Verified all 36 tests against local Azurite and the full solution build. Compared all 13 existing events through the consumer logging formatter; output is unchanged except timestamp and EventId metadata.
Yan Mahdych (ymahdych)
requested a review
from Yaroslav Tykhonchuk (yaroslav-tykhonchuk)
October 30, 2026 09:25
Yaroslav Tykhonchuk (yaroslav-tykhonchuk)
approved these changes
Oct 30, 2026
|
|
||
| var random = new Random().NextInt64(0, int.MaxValue); | ||
| BatchQueue = new BatchQueue<T>("UseDevelopmentStorage=true", $"batch-test-{random}", maxDequeueCount, logger: logger); | ||
| var connection = Environment.GetEnvironmentVariable("AZURE_BATCH_QUEUE_TEST_CONNECTION") ?? "UseDevelopmentStorage=true"; |
Collaborator
There was a problem hiding this comment.
Environment.GetEnvironmentVariable("AZURE_BATCH_QUEUE_TEST_CONNECTION")
Yan Mahdych (@ymahdych) why do we need this though?
Remove the connection override introduced only for local investigation. Keep both fixtures on the existing Azurite development-storage configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/youscan/youscan/issues/3502
BlobNotFoundfails the entire receive, forcing healthy messages to retry and eventually enter quarantine.BlobNotFoundoccurs and help determine whether these errors indicate data loss. Convert existing logs to source generation as well.