Repository navigation
Remove the Docker image - #32
Merged
Merged
Conversation
uv.lock already pins every dependency, including the PyTorch build, so uv sync gives the same environment as the image. Removing it drops a second installation path to maintain and the slowest CI job. The DEEPANESEG_GIT_COMMIT fallback, only set by the image, goes too: outside a git checkout, run_info records the commit as 'unknown'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uv.lockalready pins every dependency, including the PyTorch build, souv sync --extra cu126(orcpu) gives the same environment as the image.Removes the
Dockerfile,.dockerignore, the CI docker job and the Docker section of the README. TheDEEPANESEG_GIT_COMMITfallback, only set by the image, goes too: outside a git checkout,run_info.jsonrecords the commit asunknown.Lint, format and the 100 tests pass.