Repository navigation
Lint with ruff's default rules - #33
Merged
Merged
Conversation
The lint used E9 and pyflakes only; it now uses ruff's default rules (pycodestyle errors and pyflakes), like DeepAneDet and DeepAnePose. The fixes are mechanical: one import per line, 'is not' / 'not in' tests, imports at the top of utils.py, isinstance instead of type() !=, no single-letter 'l' names, and the experimental evaluate.py only catching file errors (it used a bare except). Behaviour is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One commit.
ruff checknow uses ruff's default rules (E4,E7,E9,F) instead ofE9+ pyflakes, like DeepAneDet and DeepAnePose; the code was already formatted.The fixes are mechanical: one import per line,
is not/not intests, the two scheduler imports moved to the top ofutils.py,isinstanceinstead oftype(...) !=, no single-letterlnames, and the experimentalevaluate.pyonly catching file errors (it used a bareexcept).No behaviour change: lint, format check and the 100 tests pass.