Repository navigation
Use WorldCover-aware FANO for SSEBop cold references - #10
Conversation
Default to OpenET-style fine/coarse FANO with ESA WorldCover v200 reference classes, automatic input acquisition, diagnostic fields and cache provenance. Retain an explicit legacy mode and document the crosswalk and spatial-support limits. Validation: 542 tests passed; offline source/wheel builds and installed-wheel demo passed. Narrabri 2018-05-25 wider-window retrieval passed its padding stability gate.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: efa2d342a0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| coarse_scale_m=tcold_coarse_scale_m, | ||
| smooth_scale_m=tcold_smooth_scale_m, | ||
| smooth_resolution_m=float(_cfg_value(cfg, args, "tcold_smooth_resolution_m", default=90.0)), | ||
| smooth_radius_pixels=int(_cfg_value(cfg, args, "tcold_smooth_radius_pixels", default=5)), |
There was a problem hiding this comment.
When tcold_smooth_radius_pixels comes from a YAML/TOML configuration or a direct API call, a fractional value such as 2.5 is silently converted to 2 here, so worldcover_fano() never reaches its explicit non-integer validation and produces results with an unintended smoothing window. Preserve the configured value until validation, or explicitly reject non-integral values before converting it.
Useful? React with 👍 / 👎.
1 participant
Green tree cover could dominate the previous cold-reference selection for dry agricultural scenes. SSEBop now defaults to an OpenET-style fine/coarse FANO calculation with ESA WorldCover v200 (2021): grassland, cropland and herbaceous wetlands are eligible regional references, while trees and mangroves are excluded from that mask. An explicit
tcold_method="legacy"preserves the previous calculation.The preparation stage downloads WorldCover over the actual exported Landsat bounds. Both run workflows carry land-cover inputs and FANO settings, include them in cache provenance, and export reference/fallback diagnostics. Documentation describes the static 2021 classification, crosswalk, spatial support and numerical differences from OpenET.
Validation: