Repository navigation
Preserve exact native grids when combining soil auxiliaries - #7
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native coarse verification stopped when soil auxiliaries had exactly matching coordinates but affine spacing reconstructed from those coordinates differed by ~3e-15 degrees. Preserve the template affine in new soil preparations, and copy existing auxiliaries onto the output grid only after exact centre/CRS checks and a coordinate-roundoff bound. Record both transforms and any metadata adjustment, without resampling values.
Final product grid checks remain exact and now inspect the declared affine so an inconsistent stored origin cannot be hidden by coordinate inference. Every copied auxiliary receives the output grid mapping.
Validation: Gadi PBS 181483937 passed 398 tests, the offline paired workflow, source/wheel builds and the installed-wheel demo. A real 10,588-day Yanco coarse export preserved all scenario and auxiliary values exactly, passed numerical/grid checks, and reproduced 174,912 fitted cell–day pairs with RMSE difference 2.17e-11. No optimizer, forcing or parameter changes. Tested/published tree: 731a5a3899fb3ee97fb1b6fb598d20eb4d6368cb.