Repository navigation
Preserve callable SWB run entry point across import orders - #8
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing
pysweb.swb.runbefore callingpysweb.swb.run(...)could replace the package entry point with a non-callable module and stop a composed workflow after calibration. Make the run module callable, following the preprocessing and calibration entry points, and retain the public API's missing-input validation and dispatch. Remove import-time attempts to overwrite the parent attribute.Regression coverage includes submodule-first, API-first and package-first imports in fresh interpreters, module aliases, dispatch, validation and module CLI execution. Gadi job 181498178 passed all 405 tests, source/wheel builds, the offline paired workflow and installed-wheel demo/API checks in the preserved project runtime. The tested tree is
8b0be2c70c100bd5f892fe0b9e27ddcc255d9acb; solver and scientific calculations are unchanged.