Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/src/ipaddr_base.dart
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ mixin _BaseV4 {
throw ValueError('At most 3 characters permitted in $x');
}
var octetInt = int.tryParse(x);
if (octetInt == null || octetInt > 255) {
if (octetInt == null || octetInt < 0 || octetInt > 255) {
throw ValueError('Octet $octetInt (> 255) not permitted');
}
return octetInt;
Expand Down Expand Up @@ -290,7 +290,7 @@ mixin _BaseV6 {
throw ValueError('At most 4 characters permitted in $hextetStr');
}
var result = int.tryParse(hextetStr, radix: 16);
if (result == null) {
if (result == null || result < 0) {
throw ValueError('Only hex digits permitted in $hextetStr');
}
return BigInt.from(result);
Expand Down
5 changes: 5 additions & 0 deletions test/ipv4address_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,11 @@ void main() {
expect(() => IPv4Address(fault), throwsA(TypeMatcher<ValueError>()));
});

test('NG: address negative octet', () {
var fault = '-1.0.0.0';
expect(() => IPv4Address(fault), throwsA(TypeMatcher<ValueError>()));
});

test('NG: plus over 4294967295', () {
var addr = IPv4Address('255.255.255.255');
expect(() => addr + 100, throwsA(TypeMatcher<AddressValueError>()));
Expand Down
6 changes: 6 additions & 0 deletions test/ipv6address_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,12 @@ void main() {
() => IPv6Address(fault), throwsA(TypeMatcher<AddressValueError>()));
});

test('NG: address negative hextet', () {
var fault = '-1::';
expect(
() => IPv6Address(fault), throwsA(TypeMatcher<AddressValueError>()));
});

test('NG: address min parts', () {
var fault = '2001:4860';
expect(
Expand Down