Make forward compatible with pre-scale - #755
Merged
Merged
Conversation
Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>
Contributor
Author
|
👍 |
szuecs
approved these changes
Sep 9, 2026
Member
|
👍 |
Member
|
I lost my write access, for some reason |
Contributor
Author
I added you now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where forward (#716, #721) in combination with
alpha.stackset-controller.zalando.org/prescale-stackswould not work and switching traffic to a forwarded stack would get stuck because the "virtual" stack was not ready.The solution is to not check for readiness of the underlying deployment, as there is no underlying deployment when the stack is marked for forwarding.