Skip to content

Parse current OnlineHashCrack API response format #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zalexdev merged 1 commit into from
Sep 22, 2026
Merged

Parse current OnlineHashCrack API response format #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions app/src/main/java/com/zalexdev/stryker/handshakes/HandshakesAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,25 @@ private static UploadResult parseUploadResult(ArrayList<String> lines) {
boolean already = message.toLowerCase(java.util.Locale.ROOT).contains("already");
return new UploadResult(already ? UploadOutcome.ALREADY : UploadOutcome.SUCCESS, message);
}
// Current OnlineHashCrack API responds with accepted/skipped/rejected counts
// instead of a success flag: {"accepted":{"count":1,...},"skipped":{...},"rejected":{...}}
org.json.JSONObject accepted = json.optJSONObject("accepted");
org.json.JSONObject skipped = json.optJSONObject("skipped");
org.json.JSONObject rejected = json.optJSONObject("rejected");
if (accepted != null || skipped != null || rejected != null) {
int acc = accepted != null ? accepted.optInt("count", 0) : 0;
int skp = skipped != null ? skipped.optInt("count", 0) : 0;
int rej = rejected != null ? rejected.optInt("count", 0) : 0;
if (acc > 0) {
return new UploadResult(UploadOutcome.SUCCESS, message);
}
if (skp > 0) {
String reason = skipped != null ? skipped.optString("reason", "") : "";
return new UploadResult(UploadOutcome.ALREADY, reason);
}
String reason = rejected != null ? rejected.optString("reason", "") : "";
return new UploadResult(UploadOutcome.FAILED, reason);
}
return new UploadResult(UploadOutcome.FAILED, message);
} catch (org.json.JSONException ignored) {
}
Expand Down